NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

adding global variable to keep track if gtkmain has been called#2604

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

fariza wants to merge1 commit intomatplotlib:masterfromfariza:keep_track_of_gtk_main_call

Closed

adding global variable to keep track if gtkmain has been called#2604

fariza wants to merge1 commit intomatplotlib:masterfromfariza:keep_track_of_gtk_main_call

Conversation

Copy link

Member

fariza commentedNov 21, 2013

When embedding plot creation in gtk (see example below)
The mainloop does not callGtk.main() because it has been called by the embedder.

ButGtk.main_quit() is called depending onis_interactive(), it doesn't take in count who calledGtk.main()

This causes that the embedder program, gets destroyed when destroying the last window of the plots.

The proposed solution is just an ugly variable added to keep track ifGtk.main() was called inside the mainloop to restrict the call ofGtk.main_quit()

This may be related to PR#2503

import matplotlibmatplotlib.use('GTK3AGG')import matplotlib.pyplot as pltfrom gi.repository import Gtkclass MyWindow(Gtk.Window):    def __init__(self):        Gtk.Window.__init__(self, title="Hello World")        self.button = Gtk.Button(label="Click Here")        self.button.connect("clicked", self.on_button_clicked)        self.add(self.button)    def on_button_clicked(self, widget):        fig = plt.figure()        ax = fig.add_subplot(111)        ax.plot([1,2,3])        plt.show()win = MyWindow()win.connect("delete-event", Gtk.main_quit)win.show_all()Gtk.main()

adding global variable to keep track if gtkmain has been called

7b4c4f6

Copy link

Member

tacaswell commentedNov 21, 2013

I don't think this is the best way to do this.

I think it is far better to factor thepyplot dependence out of thefigure_manager classes this be able to get at those with out having to importpyplot and all the state it brings with it.

Copy link

MemberAuthor

fariza commentedNov 21, 2013

@tacaswell I agree with you. As I said this is just a workaround the problem.

If you want I can do the removal of the dependencies in Gtk3, just to see how it goes.

At this moment, pyplot does know what figure manager and what canvas to use becausepyplot callspylab_setup to import the appropiate figure manager and canvas.

My first questions
How do we replace this functionality?
Where do we place it to be called automagically?

Another point that comes to mind, pyplot has thefigure method that at the end do the assembly of the figure, canvas and manager (throughnew_figure_manager andnew_figure_manager_given_figure).

My second question
Do we want to provide a similar method?

Copy link

MemberAuthor

Is there any specific reason to get rid ofGcf or even_pylab_helpers.py?
At first view I dont' see anything wrong with it and find it usefull when working with several figures.
It could be just renamed_figure_helpers.py or moved inside somewhere else

Copy link

MemberAuthor

fariza commentedNov 27, 2013

Hello

I have a preview working but I need some answers to know how do you want to reorganize the pyplot/pylab stuff.
I just removed everything, so there is no moreGcf,new_figure_manager_given_figure,new_figure_manager orShow inside the backend.

My little example is working calling figure, canvas and figuremanager form within my Gtk3 app, but of course without those helpers it is not of much use in scripting or interactive mode.

I don't want to be too intense with this, but if we don't clear this from here, it will be impossible to move forward with other things, because this is always first in the list of modifications that you propose.

Copy link

Member

tacaswell commentedNov 27, 2013

The idea is to write a second layer of classes (which keep the current names, the current classes with Gcf and company stripped need to be renamed) that sticky tape together the backendfigure_manager +Gcf to be exposed back to the rest of pyplot. I suspect that this could be done with a factory method, you feed it in a backend and Gcf, and it returns a class that replicates what the figure_manager class does now. Those classes are whatpyplot.figure talks to. That make sense?