Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
CI: Use scientific-python/upload-nightly-action#26023
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
CI: Use scientific-python/upload-nightly-action#26023
Uh oh!
There was an error while loading.Please reload this page.
Conversation
* Use the scientific-python/upload-nightly-action GitHub Action to upload the nightly wheels to the scientific-python-nightly-wheels Anaconda Cloud package index (https://anaconda.org/scientific-python-nightly-wheels). For security best practices pin at the commit sha corresponding to the last stable release and let Dependabot update the commit sha and comment as new releases come out. - c.f.https://github.com/scientific-python/upload-nightly-action
* Remove the workflow step for querying and removing all but the last 5 nightly wheel uploads to the scientific-python-nightly-wheels Anaconda Cloud package index as this is now centrally done by the Scientific Python org for all projects that upload tohttps://anaconda.org/scientific-python-nightly-wheels. - c.f.scientific-python/upload-nightly-action#12
Uh oh!
There was an error while loading.Please reload this page.
As far as the removals go, upstream does not yetactually implement deleting, but I'm fine with saying "oh, they will, and if it becomes an actual problem before they do, easy enough to put back, so cross that bridge when we come to it" |
matthewfeickert commentedJun 1, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Yeah, and asscientific-python/upload-nightly-action#12 will probably be merged in the next 24 hours I don't see any harm in there potentially being 6 wheels up on the package index for a few hours in the worst case scenario. As soon as it is merged I'm also going to trigger a manual run of the wheel removal workflow with workflow dispatch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Seems good to me, but I guess we should wait until at least one nightly wheel is uploaded using the new location, instead of stacking these two changes together.
matthewfeickert commentedJun 1, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
@ksunden has you covered and did this a few days ago. :) https://anaconda.org/scientific-python-nightly-wheels/matplotlib/files
$docker run --rm -ti python:3.11 /bin/bashroot@e22e7dd70b46:/#python -m pip download --index-url https://pypi.anaconda.org/scientific-python-nightly-wheels/simple --no-deps matplotlibLooking in indexes: https://pypi.anaconda.org/scientific-python-nightly-wheels/simpleCollecting matplotlib Downloading https://pypi.anaconda.org/scientific-python-nightly-wheels/simple/matplotlib/3.8.0.dev1157%2Bg2f778fda79/matplotlib-3.8.0.dev1157%2Bg2f778fda79-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (11.6 MB) ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 11.6/11.6 MB 11.3 MB/s eta 0:00:00Saved /matplotlib-3.8.0.dev1157+g2f778fda79-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whlSuccessfully downloaded matplotlibWARNING: There was an error checking the latest version of pip.root@e22e7dd70b46:/#ls matplotlib-3.8.0.dev1157+g2f778fda79-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whlmatplotlib-3.8.0.dev1157+g2f778fda79-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whlroot@e22e7dd70b46:/# edit: Er, sorry maybe you meantautomatically uploaded using the changes in PR#25950? |
That was manual though, and won't confirm the workflow is working. |
Gotcha. 👍 Okay that will happen later tonight then now that PR#25950 is in. After that happens, if you'd like to see an additional example of the workflow
|
matthewfeickert commentedJun 1, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Oh but you want to check that the |
And withhttps://github.com/matplotlib/matplotlib/actions/runs/5151045894/jobs/9275848789 that's up and deploying correctly $docker run --rm -ti python:3.11 /bin/bashroot@b6fb237233dd:/#python -m pip download --index-url https://pypi.anaconda.org/scientific-python-nightly-wheels/simple --no-deps matplotlibLooking in indexes: https://pypi.anaconda.org/scientific-python-nightly-wheels/simpleCollecting matplotlib Downloading https://pypi.anaconda.org/scientific-python-nightly-wheels/simple/matplotlib/3.8.0.dev1192%2Bgbb335a115c/matplotlib-3.8.0.dev1192%2Bgbb335a115c-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whl (11.6 MB) ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 11.6/11.6 MB 6.9 MB/s eta 0:00:00Saved /matplotlib-3.8.0.dev1192+gbb335a115c-cp311-cp311-manylinux_2_17_x86_64.manylinux2014_x86_64.whlSuccessfully downloaded matplotlibWARNING: There was an error checking the latest version of pip.root@b6fb237233dd:/# 👍 |
scientific-python/upload-nightly-action#12 is now merged and has been run successfully (c.f.scientific-python/upload-nightly-action#12 (comment)). |
Uh oh!
There was an error while loading.Please reload this page.
PR summary
Follow up PR to PR#25950.
Use the
scientific-python/upload-nightly-actionGitHub Action to upload the nightly wheels to thescientific-python-nightly-wheelsAnaconda Cloud package index. For security best practices pin at the commit sha corresponding to the last stable release and let Dependabot update the commit sha and comment as new releases come out.Remove the workflow step for querying and removing all but the last 5 nightly wheel uploads to the scientific-python-nightly-wheels Anaconda Cloud package index as this is now centrally done by the Scientific Python org for all projects that upload tohttps://anaconda.org/scientific-python-nightly-wheels.
PR checklist