Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

[Doc]: Fix navigation sidebar for Animation examples#25977

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 1 commit intomatplotlib:mainfromMubin17:Mubin17/Issue#25836
May 25, 2023

Conversation

Mubin17
Copy link
Contributor

@Mubin17Mubin17 commentedMay 25, 2023
edited
Loading

PR summary

This pull request is to address Issue#25836

PR checklist

@Mubin17
Copy link
ContributorAuthor

Mubin17 commentedMay 25, 2023
edited
Loading

@QuLogic@rcomer@codingtosh automatic check of the doc build and a link that allows us to view how the docs look is working now. Based on a quick check the side navigation seems to be working fine as well.

rcomer reacted with thumbs up emoji

Copy link
Member

@melissawmmelissawm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks great to me, thanks again@Mubin17 !

@codingtosh
Copy link

@Mubin17 LGTM,desired outcome is achieved. 🎉

Just a nit for next time, it will help with maintenance if youprovide more context in your commit messages. Finding out which files were changed can be known by usinggit log --stat /git log --name-only if someone was going through the logs or by git diff /git show if someone wanted to reference your commit in particular, commit message should focus on the changes introduced and why, what they fix, any future scope etc.

@melissawm Thanks for the code suggestions 👍

Mubin17 reacted with thumbs up emojimelissawm reacted with heart emoji

@QuLogicQuLogic added this to thev3.7-doc milestoneMay 25, 2023
@QuLogicQuLogic changed the title[Doc][Examples Gallery]: Side Navigation Section breaks on Animation[Doc]: Fix navigation sidebar for Animation API pageMay 25, 2023
@QuLogicQuLogic changed the title[Doc]: Fix navigation sidebar for Animation API page[Doc]: Fix navigation sidebar for Animation examplesMay 25, 2023
@QuLogicQuLogic merged commit28a0205 intomatplotlib:mainMay 25, 2023
@QuLogic
Copy link
Member

I squash merged to fix the commit message.

@QuLogic
Copy link
Member

Thanks@Mubin17! Congratulations on your first PR to Matplotlib 🎉 We hope to hear from you again.

codingtosh reacted with hooray emoji

QuLogic added a commit that referenced this pull requestMay 25, 2023
…977-on-v3.7.1-docBackport PR#25977 on branch v3.7.1-doc ([Doc]: Fix navigation sidebar for Animation examples)
rcomer added a commit that referenced this pull requestMay 25, 2023
…977-on-v3.7.xBackport PR#25977 on branch v3.7.x ([Doc]: Fix navigation sidebar for Animation examples)
@Mubin17Mubin17 deleted the Mubin17/Issue#25836 branchMay 26, 2023 04:09
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

@melissawmmelissawmmelissawm approved these changes

Assignees
No one assigned
Projects
Milestone
v3.7-doc
Development

Successfully merging this pull request may close these issues.

4 participants
@Mubin17@codingtosh@QuLogic@melissawm

[8]ページ先頭

©2009-2025 Movatter.jp