Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
more explicit about what remote means in context#25845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
building off ofmatplotlib#25828 and@timhoffm's comment, mostly reworded/movedthings (very little if any change in length) to try and make it moreexplicit that in this context origin and upstream are aliases forremote repositories.Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Take or leave my Suggestion und the link.
doc/devel/development_setup.rst Outdated
| @@ -82,6 +80,10 @@ so that you can access the latest changes there (see also `Managing remote repos | |||
| git remote add upstream git@github.com:matplotlib/matplotlib.git | |||
| You can now use ``upstream`` to retrieve the most current snapshot of the source | |||
| code, as described in :ref:`development-workflow`. See also `Managing remote repositories | |||
| <https://docs.github.com/en/get-started/getting-started-with-git/managing-remote-repositories>`__. | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I propose to move the "Managing remote repositories" link to the notes section below (or remove it completely). While it is about remotes, it only covers rarely needed management operations on remotes, not something one would need for regular development work:
Adding a remote repository. - we've covered that ourselves
Changing a remote repository's URL - the matplotlib repository won't move
Renaming a remote repository - no need to change the nameupstream
Removing a remote repository - no need to decouple from upstream
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Sure, just building locally now. I like having some words under code blocks and pictures to complete out a section, but here the link to the dev workflow does the trick.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ok,so I thought the notes were getting unwieldy so I took the easy route of putting them into a dropdown (that I left open by default so I haven't changed the look)
@meeseeksdev backport to v3.7.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free tosuggest an improvement. |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free tosuggest an improvement. |
OK, not sure why it didn't post that the first time, but not going to go through the trouble of backporting myself. |
building off of#25828 and@timhoffm's comment, mostly reworded/moved things (very little if any change in length) to try and make it more explicit that in this context origin and upstream are aliases for remote repositories.