If neither are specified at object creation, the default is to beNone. This brokeget_{cap,join}style when the enum wrappers were created as they assume the internal value is always an enum value.

$ python -c 'from matplotlib.collections import Collection; print(Collection().get_capstyle())'Traceback (most recent call last):  File "<string>", line 1, in <module>  File ".../lib/matplotlib/collections.py", line 643, in get_capstyle    return self._capstyle.nameAttributeError: 'NoneType' object has no attribute 'name'$ python -c 'from matplotlib.collections import Collection; print(Collection().get_joinstyle())'Traceback (most recent call last):  File "<string>", line 1, in <module>  File ".../lib/matplotlib/collections.py", line 657, in get_joinstyle    return self._joinstyle.nameAttributeError: 'NoneType' object has no attribute 'name'

This was broken since the initial addition of the enums in#18544, so I'm not sure if it should be backported (minus the typing changes.)

PR checklist

[n/a] "closes #0000" is in the body of the PR description tolink the related issue
new and changed code istested
[n/a]Plotting related features are demonstrated in anexample
[n/a]New Features andAPI Changes are noted with adirective and release note
[n/a] Documentation complies withgeneral anddocstring guidelines

Copy link

Member

ksunden commentedMay 4, 2023•
edited
Loading

The alternative would be to resolve to the default. As far as I can tell the default is hard codedhere, so not controlled by rcparam. I suppose backendscould override the default? But not convinced that edge case is worth accounting for.

Copy link

MemberAuthor

QuLogic commentedMay 4, 2023

Yes, this was added in#9523 and, ifNone, defaulted to backend renderer state. Also,#17575 documented this as defaulting to thepatch.{cap,join}style rcParam, but that doesn't appear to be true. Alternatively we could start defining a default for collections as documented.

Either way, we should probably fix the default and documented default to match.

ksunden added this to thev3.8.0 milestone

Jul 26, 2023

ksunden approved these changes

Jul 26, 2023

View reviewed changes

Copy link

Member

ksunden commentedJul 26, 2023

Test failure is almost certainly the MacOS/Azure/Tk problem we were having.

Fix default return of Collection.get_{cap,join}style

4b99bc6

If neither are specified at object creation, the default is to be`None`. This broke `get_{cap,join}style` when the enum wrappers werecreated as they assume the internal value is always an enum value.

QuLogic force-pushed thefix-default-collection-style branch from2f4f08e to4b99bc6Compare

July 27, 2023 07:50