Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Remove some examples from Userdemo#25801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 1 commit intomatplotlib:mainfromtimhoffm:remove-userdemo
Feb 7, 2025

Conversation

timhoffm
Copy link
Member

PR summary

Partly adresses#25800. See the individual commit messages.

@timhoffmtimhoffm added this to thev3.8.0 milestoneMay 1, 2023
@timhoffmtimhoffm changed the titleRemove userdemoRemove some examples from UserdemoMay 1, 2023
legend box.

By default, Axes fill the whole figure area, and thus legends placed outside would
be cut of. We therefore use a layout manager to resize everything so that the legend
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change
becutof.Wethereforeusealayoutmanagertoresizeeverythingsothatthelegend
becutoff.Wethereforeusealayoutmanagertoresizeeverythingsothatthelegend

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The legend example will be handled in a separate PR. - Excluded here for now.

fig, ax = plt.subplots(layout='constrained')
ax.plot([1, 2, 3], label="line 1")
ax.plot([3, 2, 1], label="line 2")
ax.legend(bbox_to_anchor=(1.05, 1), loc='upper left', borderaxespad=0)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Should we also mention the newoutside upper left (#19743)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The User Guide is pretty comprehensive on that. I'm not sure what the thinking is in general about duplicating information across examples/tutorials/guide.
https://matplotlib.org/devdocs/users/explain/axes/legend_guide.html#figure-legends

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks for making me aware of the duplication. I'll check how to handle this best.

Copy link
MemberAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

The legend example will be handled in a separate PR. - Excluded here for now.

@timhoffmtimhoffm marked this pull request as draftMay 2, 2023 11:32
@ksundenksunden modified the milestones:v3.8.0,v3.8-docAug 8, 2023
@QuLogicQuLogic mentioned this pull requestAug 3, 2024
2 tasks
@QuLogic
Copy link
Member

Ping?

@timhoffm
Copy link
MemberAuthor

I will come back to this.

@github-actionsgithub-actionsbot added the Documentation: examplesfiles in galleries/examples labelFeb 6, 2025
@timhoffmtimhoffm modified the milestones:v3.8-doc,v3.10.0-docFeb 6, 2025
@timhoffm
Copy link
MemberAuthor

I've reduced the PR to moving only two obvious gridspec examples. The rest will be handled in a separate PR.

While we should consolidate the examples for creating complex Axeslayouts (or rather have a guide on this), that's beyond the scope ofthis PR. All these examples are special enough so that we want to keepthem until we have something better.
@github-actionsgithub-actionsbot added the Documentation: user guidefiles in galleries/users_explain or doc/users labelFeb 6, 2025
@timhoffmtimhoffm marked this pull request as ready for reviewFebruary 6, 2025 12:05
@QuLogicQuLogic merged commitc5e4aec intomatplotlib:mainFeb 7, 2025
22 checks passed
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestFeb 7, 2025
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestFeb 7, 2025
QuLogic added a commit that referenced this pull requestFeb 7, 2025
…801-on-v3.10.xBackport PR#25801 on branch v3.10.x (Remove some examples from Userdemo)
@timhoffmtimhoffm deleted the remove-userdemo branchFebruary 7, 2025 05:42
timhoffm added a commit that referenced this pull requestFeb 7, 2025
…801-on-v3.10.0-docBackport PR#25801 on branch v3.10.0-doc (Remove some examples from Userdemo)
@ksundenksunden mentioned this pull requestMar 3, 2025
5 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@rcomerrcomerrcomer left review comments

@QuLogicQuLogicQuLogic approved these changes

Assignees
No one assigned
Labels
Documentation: examplesfiles in galleries/examplesDocumentation: user guidefiles in galleries/users_explain or doc/usersDocumentation
Projects
None yet
Milestone
v3.10-doc
Development

Successfully merging this pull request may close these issues.

4 participants
@timhoffm@QuLogic@rcomer@ksunden

[8]ページ先頭

©2009-2025 Movatter.jp