Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Add auto-scaling support to "add_collection3d"#25751

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed
lganic wants to merge7 commits intomatplotlib:mainfromlganic:main

Conversation

lganic
Copy link
Contributor

@lganiclganic commentedApr 22, 2023
edited
Loading

PR Summary

closes#17130

Adds support for auto-scaling 3D collection objects in the add_collection3d function. The new implementation is consistent with the behavior of the existing 2D implementation, where auto-scaling is True by default.

Test cases were added for each of the relevant autoscaling functions.

The autoscaling works with most 2D/3D collections; the only collection I wasn't able to get working was Patch3DCollection, which (as far as I can tell) seems to have a number of ongoing bugs that make them borderline unusable, and untestable.

Also turns out that a few of the test cases suffered from the bug seen in#17130, so I updated the failing tests accordingly.

PR Checklist

Linked Issue

  • Added "closes #0000" in the PR description to link it to the original issue.

Documentation and Tests

  • Has pytest style unit tests (andpytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a.. versionadded:: directive in the docstring and documented indoc/users/next_whats_new/
  • API changes are marked with a.. versionchanged:: directive in the docstring and documented indoc/api/next_api_changes/
  • Release notes conform with instructions innext_whats_new/README.rst ornext_api_changes/README.rst

@scottshambaugh
Copy link
Contributor

scottshambaugh commentedMay 5, 2023
edited
Loading

I believe this may also close#23317, and we should check if it closes#14298 as well.

Copy link
Member

@QuLogicQuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We would prefer if you could rebase instead of merge. It appears there are some completely unrelated commits in this PR that shouldn't be here.

# If a 2D collection was passed, it has been converted to 3D

if autolim:
if type(col) is art3d.Line3DCollection:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Is there a reason to not useisinstance here?

@scottshambaugh
Copy link
Contributor

Hi@lganic, are you still interested in working on this PR?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic requested changes

Assignees
No one assigned
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

autoscale_view is not working with Line3DCollection
3 participants
@lganic@scottshambaugh@QuLogic

[8]ページ先頭

©2009-2025 Movatter.jp