Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add test for Path.contains_path#25730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 1 commit intomatplotlib:mainfromoscargus:testpathinpath
Apr 21, 2023

Conversation

oscargus
Copy link
Member

PR Summary

This was untested.

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (andpytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a.. versionadded:: directive in the docstring and documented indoc/users/next_whats_new/
  • API changes are marked with a.. versionchanged:: directive in the docstring and documented indoc/api/next_api_changes/
  • Release notes conform with instructions innext_whats_new/README.rst ornext_api_changes/README.rst

@oscargusoscargus changed the titleAdd test for Path.path_in_pathAdd test for Path.contains_pathApr 20, 2023
@tacaswell
Copy link
Member

doc failure is due to the issues with the website.

@tacaswelltacaswell added this to thev3.8.0 milestoneApr 20, 2023
Copy link
Member

@timhoffmtimhoffm left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Can we add a test case with a non convex polygon so that all points of the other are inside, but some part of the edge goes outside; e.g. (sorry for the poor formatting, I’m on mobile)

-0.1, -0.1
-0.1, 1.2
0.5, 0.8
1.1, 1.2
1.1, -0.1

This is a rectangle with a kink at the top so that all nodes of the unit square are inside, but the top edge of the unit square is partially outside.

@oscargus
Copy link
MemberAuthor

I've added such a test (third one).

timhoffm reacted with thumbs up emoji

@timhoffmtimhoffm merged commite631edb intomatplotlib:mainApr 21, 2023
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.8.0
Development

Successfully merging this pull request may close these issues.

3 participants
@oscargus@tacaswell@timhoffm
[8]ページ先頭
©2009-2025 Movatter.jp