Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Splitting navigation and toolbar#2557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Closed

Conversation

fariza
Copy link
Member

This is in response to the request to split#2465 into several smaller PRs.

Goals

Main Goal

Separate the navigation state from the GUI (or physical) toolbar. Without touching any base class (as much as possible), to avoid forced refactor of other backends.

Secondary Goal

Add reconfiguration capabilities to the toolbar

Implementation

The following base classes were added

  • NavigationBase: a derivate of NavigationToolbar2. This is the class that holds the state of the navigation.
  • ToolbarBase: This is the physical or GUI toolbar. with the following new public methods
    • remove_tool
    • add_tool
    • move_tool

Includes Gtk3 implementation

  • NavigationGTK3
  • ToolbarGTK3
  • Simple example of use examples/user_interfaces/reconfigurable_toolbar_gtk3.py

Future

If the functionality is worth the effort, and all the backends are ported to use this classes, it will be possible to merge NavigationBase and NavigationToolbar2.

Note

This is very similar to the idea of#1849 different implementation without touching the bases classes.

@farizafariza mentioned this pull requestOct 28, 2013
@farizafariza closed thisJan 29, 2014
@farizafariza deleted the reconfigurable-toolbar branchFebruary 11, 2015 18:10
@QuLogicQuLogic modified the milestones:unassigned,proposed next point release (2.1)Oct 11, 2015
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@fariza@QuLogic

[8]ページ先頭

©2009-2025 Movatter.jp