Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

DOC: Fix the bars having numeric value of cm but labeled as inches#25518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 1 commit intomatplotlib:mainfromksunden:bar_demo_units
Mar 23, 2023

Conversation

ksunden
Copy link
Member

This is admittedly more of a band-aid than a proper fix, but at least
make the generated figure correct.

The underlying problem is the more fundemental one of inconsistent units
behavior in which some artists can be re-united after plotting (e.g.
Line2D), while many others (e.g. Collections) cannot.

Thus, until that is addressed (which is one of the goals of the
data-prototype work), simply setting units early is as good as we can
do.

Closes#5051

PR Summary

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (andpytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a.. versionadded:: directive in the docstring and documented indoc/users/next_whats_new/
  • API changes are marked with a.. versionchanged:: directive in the docstring and documented indoc/api/next_api_changes/
  • Release notes conform with instructions innext_whats_new/README.rst ornext_api_changes/README.rst

This is admittedly more of a band-aid than a proper fix, but at leastmake the generated figure correct.The underlying problem is the more fundemental one of inconsistent unitsbehavior in which some artists can be re-united after plotting (e.g.Line2D), while many others (e.g. Collections) cannot.Thus, until that is addressed (which is one of the goals of thedata-prototype work), simply setting units early is as good as we cando.Closesmatplotlib#5051
@ksundenksunden added this to thev3.7-doc milestoneMar 20, 2023
@ksunden
Copy link
MemberAuthor

ksunden commentedMar 20, 2023
edited
Loading

Current version (the dataset changed from 3.6 to 3.7 here, but the units misbehavior was retained):https://matplotlib.org/3.7.0/gallery/units/bar_unit_demo.html

Note that the values are set in cm, but the units are supposed to be "inches", but the plotted values are the same as the cm values.

@jklymak
Copy link
Member

I'm 95% sure unit re-setting is possibleonly forLine2D, and was never implemented for anything else.

@timhoffmtimhoffm merged commitc948e90 intomatplotlib:mainMar 23, 2023
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestMar 23, 2023
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestMar 23, 2023
oscargus added a commit that referenced this pull requestMar 23, 2023
…518-on-v3.7.1-docBackport PR#25518 on branch v3.7.1-doc (DOC: Fix the bars having numeric value of cm but labeled as inches)
oscargus added a commit that referenced this pull requestMar 23, 2023
…518-on-v3.7.xBackport PR#25518 on branch v3.7.x (DOC: Fix the bars having numeric value of cm but labeled as inches)
@hamogu
Copy link
Contributor

closed a 4-digit issue. Yeah!

oscargus reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jklymakjklymakjklymak approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.7-doc
Development

Successfully merging this pull request may close these issues.

Docs: Units example broken
4 participants
@ksunden@jklymak@hamogu@timhoffm

[8]ページ先頭

©2009-2025 Movatter.jp