Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

ci: Merge sdist and wheel building workflows#25473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ksunden merged 1 commit intomatplotlib:mainfromQuLogic:test-wheel
Jun 1, 2023

Conversation

QuLogic
Copy link
Member

@QuLogicQuLogic commentedMar 15, 2023
edited
Loading

PR Summary

This allows verifying that wheels can be installed after building, and that the sdist can be built into a wheel without a second workflow.

Also simplify some of the checking scripts.

PR Checklist

Documentation and Tests

  • [n/a] Has pytest style unit tests (andpytest passes)
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • [n/a] New plotting related features are documented with examples.

Release Notes

  • [n/a] New features are marked with a.. versionadded:: directive in the docstring and documented indoc/users/next_whats_new/
  • [n/a] API changes are marked with a.. versionchanged:: directive in the docstring and documented indoc/api/next_api_changes/
  • [n/a] Release notes conform with instructions innext_whats_new/README.rst ornext_api_changes/README.rst

@QuLogicQuLogic added the CI: Run cibuildwheelRun wheel building tests on a PR labelMar 15, 2023
@tacaswelltacaswell added this to thev3.8.0 milestoneMar 15, 2023
@QuLogicQuLogic changed the titlec: Verify that wheels can be installed after buildingci: Verify that wheels can be installed after buildingMar 15, 2023
@QuLogic
Copy link
MemberAuthor

QuLogic commentedMar 15, 2023
edited
Loading

So some annoyance here: we still build 32-bit wheels, but NumPy doesn't. When we build ourselves, we ask foroldest-supported-numpy and build a 32-bit wheel of it. But then for the test, our requirement is justnumpy>=MINIMUM, so then we have to build NumPyagain becausepip picks the latest.

This will probably also affect some of the ARM builds? Which will really explode the runtime for this workflow. Maybe we'll have to get by without the test...

@greglucas
Copy link
Contributor

I'm not following how an echo on the test command verifies that it didn't totally fail. Don't you need topip install wheelhouse/*.whl to verify that it can be installed?

To avoid the long stacked wheel builds in a single job, I've switched over to dynamically generating the run matrix on other projects which has worked nicely:pypa/cibuildwheel#1261

Perhaps we should open a separate issue about the 32-bit wheels, but it seems like if Numpy has dropped direct wheel support, we could probably follow suit as well and not bother with the extra maintenance there.

@QuLogic
Copy link
MemberAuthor

cibuildwheel creates the test environment and installs the wheel when there's a test command. Setting the environment variable just triggers this behaviour; it doesn't matter that it doesn't do anything.

I opened#25475 for dropping 32-bit wheels.

We did discuss doing a bit more testing, but that can wait for after the above change.

greglucas reacted with thumbs up emoji

@greglucas
Copy link
Contributor

cibuildwheel creates the test environment and installs the wheel when there's a test command. Setting the environment variable just triggers this behaviour; it doesn't matter that it doesn't do anything.

That wasn't obvious to me, thanks for clarifying! I did go in and look at the CI log to verify that does work 👍 . Perhaps add a comment above that to indicate as much?

@ksunden
Copy link
Member

Looks like there was a temporary disruption in the qhull download

@QuLogic
Copy link
MemberAuthor

QuLogic commentedMar 16, 2023
edited
Loading

I've realized that thecibuildsdist.whl workflow does some roughly equivalent test already. But that is on wheels that we don't end up distributing. So instead of closing this, I'm going to repurpose it to merge those two workflows so that weare checking distributed wheels. But this will wait for after dropping 32-bit wheels.

tacaswell reacted with thumbs up emoji

@QuLogic
Copy link
MemberAuthor

Sorry, that took a few tries to get working across platforms.

Annnd now we know that PyPy wheels don't import on Windows. Can anyone try that out with the release wheels? Or the previous nightly wheels?

@QuLogicQuLogic changed the titleci: Verify that wheels can be installed after buildingci: Merge sdist and wheel building workflowsMar 18, 2023
@QuLogic
Copy link
MemberAuthor

Well, it seems to have magically fixed itself in the meantime.

This allows verifying that wheels can be installed after building, andthat the sdist can be built into a wheel without a second workflow.Also simplify some of the checking scripts.
@ksundenksunden merged commit3fc25bb intomatplotlib:mainJun 1, 2023
@QuLogicQuLogic deleted the test-wheel branchJune 1, 2023 01:56
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

@ksundenksundenksunden approved these changes

Assignees
No one assigned
Labels
CI: Run cibuildwheelRun wheel building tests on a PR
Projects
None yet
Milestone
v3.8.0
Development

Successfully merging this pull request may close these issues.

4 participants
@QuLogic@greglucas@ksunden@tacaswell

[8]ページ先頭

©2009-2025 Movatter.jp