NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

CI: skip appveyor for doc only change#25383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

QuLogic merged 1 commit intomatplotlib:mainfromrcomer:appveyor-docs

Mar 6, 2023

Merged

CI: skip appveyor for doc only change#25383

QuLogic merged 1 commit intomatplotlib:mainfromrcomer:appveyor-docs

Mar 6, 2023

Conversation

Copy link

Member

rcomer commentedMar 4, 2023

PR Summary

Consistent with recent changes for CI on other platforms (#25145,#25261), this change should mean the Appveyor CI is skipped if the only changes are underdoc or in thegalleries, or if[ci doc] is in the commit message. Following the guidance here:
https://www.appveyor.com/docs/how-to/filtering-commits/

I added[ci doc] to the current commit, to test it works.

PR Checklist

Documentation and Tests

Has pytest style unit tests (andpytest passes)
Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
New plotting related features are documented with examples.

Release Notes

New features are marked with a.. versionadded:: directive in the docstring and documented indoc/users/next_whats_new/
API changes are marked with a.. versionchanged:: directive in the docstring and documented indoc/api/next_api_changes/
Release notes conform with instructions innext_whats_new/README.rst ornext_api_changes/README.rst

greglucas approved these changes

Mar 4, 2023

View reviewed changes

Copy link

Contributor

greglucas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good, but oddly enough this worked while the GitHub Actions tests still ran! So the GitHub Actions version might be incorrect...

.appveyor.yml Outdated

Comment on lines 16 to 18

		- 'galleries/examples/**'
		- 'galleries/plot_types/**'
		- 'galleries/tutorials/**'

Copy link

Contributor

greglucasMar 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Suggested change

	-'galleries/examples/**'
	-'galleries/plot_types/**'
	-'galleries/tutorials/**'
	-'galleries/**'

I think we can just skip the entire galleries directory.

CI: skip appveyor for doc only change [ci doc]

5958bd4

rcomer force-pushed theappveyor-docs branch frome371076 to5958bd4Compare

March 4, 2023 17:46

Copy link

MemberAuthor

rcomer commentedMar 4, 2023

the GitHub Actions tests still ran!

Yeah, I've been digging around the docs for that, as I've noticed it before. From what I can tell,head_commit is a property of apush event, but not of apull_request event. So possibly it just can't work for PR CI?