Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Pin mpl-sphinx-theme on the v3.7.x branch#25307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 1 commit intomatplotlib:v3.7.xfromQuLogic:pin-theme
Mar 1, 2023

Conversation

QuLogic
Copy link
Member

PR Summary

A similar thing was done for thev3.6.x branch.

PR Checklist

Documentation and Tests

  • [n/a] Has pytest style unit tests (andpytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • [n/a] New plotting related features are documented with examples.

Release Notes

  • [n/a] New features are marked with a.. versionadded:: directive in the docstring and documented indoc/users/next_whats_new/
  • [n/a] API changes are marked with a.. versionchanged:: directive in the docstring and documented indoc/api/next_api_changes/
  • [n/a] Release notes conform with instructions innext_whats_new/README.rst ornext_api_changes/README.rst

@QuLogicQuLogic added the Documentation: buildbuilding the docs labelFeb 23, 2023
@QuLogicQuLogic added this to thev3.7.1 milestoneFeb 23, 2023
@tacaswell
Copy link
Member

This should also go in the release guide updates?

@QuLogic
Copy link
MemberAuthor

Yes, probably; cc@ksunden

@QuLogicQuLogic changed the titlePin mpl-shinx-theme for v3.7.x branchPin mpl-sphinx-theme on the v3.7.x branchFeb 23, 2023
@ksunden
Copy link
Member

ksunden commentedFeb 23, 2023
edited
Loading

Is there any reason not to pin this way onmain? Its our own first party dependency that we control the release cycle of. While we currently version it for every (feature) release, it could in theory slow down that it doesn't need to be updated for each mpl release.

I feel like updating the pin is already a part of the theme release (we only updated it because we want to change/fix something, essentially), but changing it to~= from>= doesn't change that procedure, and we pretty much always want to pin it to the most recent version.

If it is pinned on main, then there is nothing special to do for release, and just the repinning to newer versions doesn't get backported.

@tacaswell
Copy link
Member

fair point. I am in general against hard pins, but this is in an internal requirements file we use for setting up CI + developers machines (not something carved into stone on pypi or a packaging system) so I guess that would be OK.

@QuLogicQuLogic merged commitddd817f intomatplotlib:v3.7.xMar 1, 2023
@QuLogicQuLogic deleted the pin-theme branchMarch 1, 2023 07:06
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

Assignees
No one assigned
Labels
Documentation: buildbuilding the docs
Projects
None yet
Milestone
v3.7.1
Development

Successfully merging this pull request may close these issues.

3 participants
@QuLogic@tacaswell@ksunden

[8]ページ先頭

©2009-2025 Movatter.jp