Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Pin mpl-sphinx-theme on the v3.7.x branch#25307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This should also go in the release guide updates? |
Yes, probably; cc@ksunden |
ksunden commentedFeb 23, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Is there any reason not to pin this way on I feel like updating the pin is already a part of the theme release (we only updated it because we want to change/fix something, essentially), but changing it to If it is pinned on main, then there is nothing special to do for release, and just the repinning to newer versions doesn't get backported. |
fair point. I am in general against hard pins, but this is in an internal requirements file we use for setting up CI + developers machines (not something carved into stone on pypi or a packaging system) so I guess that would be OK. |
PR Summary
A similar thing was done for the
v3.6.x
branch.PR Checklist
Documentation and Tests
pytest
passes)Release Notes
.. versionadded::
directive in the docstring and documented indoc/users/next_whats_new/
.. versionchanged::
directive in the docstring and documented indoc/api/next_api_changes/
next_whats_new/README.rst
ornext_api_changes/README.rst