Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

CI: Pin reviewdog eslint to use node 18.13#25262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
rcomer merged 1 commit intomatplotlib:mainfromgreglucas:ci-reviewdog-eslint
Feb 20, 2023

Conversation

greglucas
Copy link
Contributor

PR Summary

The reviewdog action is not compatible with npm v9 yet, and node 18.14+ comes with npm v9+.

closes#25251

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (andpytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a.. versionadded:: directive in the docstring and documented indoc/users/next_whats_new/
  • API changes are marked with a.. versionchanged:: directive in the docstring and documented indoc/api/next_api_changes/
  • Release notes conform with instructions innext_whats_new/README.rst ornext_api_changes/README.rst

The reviewdog action is not compatible with npm v9 yet, and node 18.14+comes with npm v9+.
@jklymakjklymak added the CI: testingCI configuration and testing labelFeb 19, 2023
@rcomerrcomer added this to thev3.7.1 milestoneFeb 20, 2023
@rcomerrcomer merged commitde8e9d0 intomatplotlib:mainFeb 20, 2023
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestFeb 20, 2023
rcomer added a commit that referenced this pull requestFeb 20, 2023
…262-on-v3.7.xBackport PR#25262 on branch v3.7.x (CI: Pin reviewdog eslint to use node 18.13)
@greglucasgreglucas deleted the ci-reviewdog-eslint branchFebruary 20, 2023 15:24
@rcomerrcomer mentioned this pull requestFeb 22, 2023
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jklymakjklymakjklymak approved these changes

@rcomerrcomerrcomer approved these changes

Assignees
No one assigned
Labels
CI: testingCI configuration and testing
Projects
None yet
Milestone
v3.7.1
Development

Successfully merging this pull request may close these issues.

[CI]: eslint failure
3 participants
@greglucas@jklymak@rcomer
[8]ページ先頭
©2009-2025 Movatter.jp