I'm new to Matplotlib development so not sure if this is the best way to do this. I added atransform parameter tosecondary_xaxis andsecondary_yaxis and passed that through intoSecondaryAxis._set_location(), where the transform is blended.

ifself._orientation=='x':# An x-secondary axes is like an inset axes from x = 0 to x = 1 and# from y = pos to y = pos + eps, in the parent's transAxes coords.bounds= [0,self._pos,1.,1e-10]# If a transformation is provided, use its y component rather than# the parent's transAxes. This can be used to place axes in the data# coords, for instance.iftransformisnotNone:transform=transforms.blended_transform_factory(self._parent.transAxes,transform)else:# 'y'bounds= [self._pos,0,1e-10,1]iftransformisnotNone:transform=transforms.blended_transform_factory(transform,self._parent.transAxes)# Use provided x axis# If no transform is provided, use the parent's transAxesiftransformisNone:transform=self._parent.transAxes

I also updatedtest_secondary_xy() andtest_secondary_fail() to test the transform.

I'm not entirely sure if/where I'm meant to put.. versionchanged:: in the docsting, but I'm happy to add it if it's needed.

PR Checklist

Documentation and Tests

Has pytest style unit tests (andpytest passes)
Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
New plotting related features are documented with examples.

Release Notes

New features are marked with a.. versionadded:: directive in the docstring and documented indoc/users/next_whats_new/
- API changes are marked with a.. versionchanged:: directive in the docstring and documented indoc/api/next_api_changes/
Release notes conform with instructions innext_whats_new/README.rst ornext_api_changes/README.rst

github-actionsbot reviewed

Feb 15, 2023

View reviewed changes

Copy link

github-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping@matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

Copy link

Member

jklymak commentedFeb 15, 2023

This looks really useful, and a quick glance the code is great. Can we add an example, at least in the issue that shows the usefulness of this? Probably want one in the example gallery as well. I had to read your code to understand the context here, which if I understand is to allow the secondary xaxis to have a y position specified in data co-ordinates rather than just axes co-ordinates.

If that is the case, what happens if the y data limits are set so the secondary axis is out of the Axes viewport?

jklymak changed the title~~Allow passing a transformation to a secondary plot~~Allow passing a transformation to secondary_xaxis/_yaxis

Feb 15, 2023

Copy link

ContributorAuthor

ZachDaChampion commentedFeb 15, 2023

@jklymak Yes, you are correct on the context. Right now, if an axis is out of the viewport it isn't drawn. The existing function behaves the same if you give it a location outside of the viewport. E.g.x2 = ax.secondary_xaxis(1.5) is not drawn. If we want it to do something else I'd be happy to change it.

Good point on the examples, I'll take care of that.

jklymak added status: needs documentation topic: axes labels

Feb 16, 2023

jklymak added this to thev3.8.0 milestone

Feb 16, 2023

github-actionsbot added the status: needs rebase label

Feb 24, 2023

Copy link

Member

melissawm commentedMar 9, 2023

Hi@ZachDaChampion - it seems you also need a rebase here to incorporate changes made in the main branch. Here's a handy guide:https://matplotlib.org/stable/devel/development_workflow.html#rebasing-on-upstream-main

Feel free to ping if you need more guidance!

github-actionsbot removed the status: needs rebase label

Apr 4, 2023

Copy link

Member

ksunden commentedApr 4, 2023

It appears that you did a merge instead of a rebase, which results in 884 commits (!!) showing up here.

We have some docs for recovering from situations like this:

https://matplotlib.org/stable/devel/development_workflow.html#recovering-from-mess-ups

Copy link

ContributorAuthor

ZachDaChampion commentedApr 4, 2023

It appears that you did a merge instead of a rebase, which results in 884 commits (!!) showing up here.
We have some docs for recovering from situations like this:
https://matplotlib.org/stable/devel/development_workflow.html#recovering-from-mess-ups

My bad, I didn't realize I pushed that version. Thanks for the link

ZachDaChampion force-pushed thesecondary-axes-trans-arg branch fromffb9b8e tocb55d34Compare

April 4, 2023 16:47

QuLogic reviewed

Apr 12, 2023

View reviewed changes

lib/matplotlib/axes/_axes.pyShow resolvedHide resolved

lib/matplotlib/axes/_axes.py OutdatedShow resolvedHide resolved

lib/matplotlib/axes/_secondary_axes.py OutdatedShow resolvedHide resolved

lib/matplotlib/tests/test_axes.py OutdatedShow resolvedHide resolved

Copy link

Member

QuLogic commentedApr 15, 2023

Now that we have typing stubs, it looks like you'll have to update the corresponding lines in the.pyi files. Also, please rebase to fix the CircleCI failures.

ZachDaChampion force-pushed thesecondary-axes-trans-arg branch from4af5bc1 toe33828fCompare

April 15, 2023 03:40

QuLogic mentioned this pull request

Apr 15, 2023

[Bug]: Secondary axis does not support Transform as functions#25691

Closed

QuLogic reviewed

Apr 15, 2023

View reviewed changes

galleries/examples/subplots_axes_and_figures/secondary_axis.py OutdatedShow resolvedHide resolved

ksunden reviewed

Apr 17, 2023

View reviewed changes

lib/matplotlib/axes/_secondary_axes.py OutdatedShow resolvedHide resolved

ZachDaChampion force-pushed thesecondary-axes-trans-arg branch fromb2d2bc7 to941f455Compare

April 20, 2023 21:00

Copy link

Member

melissawm commentedMay 24, 2023

Gentle ping to the reviewers - can you take another look here? Thanks!

QuLogic reviewed

May 27, 2023

View reviewed changes

Copy link

Member

QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Just a couple minor fixes.

lib/matplotlib/axes/_axes.py OutdatedShow resolvedHide resolved

lib/matplotlib/axes/_secondary_axes.py OutdatedShow resolvedHide resolved

Copy link

ContributorAuthor

ZachDaChampion commentedMay 31, 2023

I can rebase later if needed

QuLogic approved these changes

Jul 22, 2023

View reviewed changes

Copy link

Member

QuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Sorry we took a while to get back to this again. Just a couple minor fixes, but otherwise LGTM.

galleries/examples/subplots_axes_and_figures/secondary_axis.py Outdated


		fig, ax = plt.subplots(layout='constrained')
		x = np.arange(0, 10)
		np.random.seed(34)

Copy link

Member

QuLogicJul 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

We almost always use 19680801 as seed

Suggested change

	np.random.seed(34)
	np.random.seed(19680801)

lib/matplotlib/axes/_axes.py Outdated

		else:
		raise ValueError('secondary_yaxis location must be either '
		if not (location in ['left', 'right'] or isinstance(location, Real)):
		raise ValueError('secondary_xaxis location must be either '

Copy link

Member

QuLogicJul 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Typo:

Suggested change

	raiseValueError('secondary_xaxis location must be either '
	raiseValueError('secondary_yaxis location must be either '

lib/matplotlib/axes/_secondary_axes.py Outdated

Comment on lines 99 to 100

		# Make sure transform is a Transform or None.
		_api.check_isinstance((transforms.Transform, None), transform=transform)

Copy link

Member

QuLogicJul 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I wouldn't bother with the comment; the function call is clear:

Suggested change

	# Make sure transform is a Transform or None.
	_api.check_isinstance((transforms.Transform,None),transform=transform)
	_api.check_isinstance((transforms.Transform,None),transform=transform)

QuLogic removed the status: needs documentation label

Jul 22, 2023

ksunden modified the milestones:v3.8.0,v3.9.0

Aug 8, 2023

github-actionsbot added the status: needs rebase label

Dec 12, 2023

Allow passing a transformation to secondary_[xy]axis

c1b51aa

Add transform argument to secondary axesUpdate _secax_docstringMove new params to end of functionsAdd input check to secondary axesAdd testsAdd examplesMove transform type checks and improve docsAdd type stubsUpdate _secax_docstringMove new params to end of functionsAdd input check to secondary axesMove transform type checks and improve docsFix rebase errorFix stub for SecondaryAxis.__init__Clarify exampleAdd default param to secax constructorFix stub for secax constructorSimplify importsCo-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>Remove redundancy in docsCo-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>Fix typo

QuLogic force-pushed thesecondary-axes-trans-arg branch from4905246 toc1b51aaCompare

February 23, 2024 02:29

github-actionsbot added Documentation: examplesfiles in galleries/examples and removed topic: axes status: needs rebase labels

Feb 23, 2024

Copy link

Member