[N/A] Has pytest style unit tests (andpytest passes)
[N/A] Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
[N/A] New plotting related features are documented with examples.

Release Notes

New features are marked with a.. versionadded:: directive in the docstring and documented indoc/users/next_whats_new/
API changes are marked with a.. versionchanged:: directive in the docstring and documented indoc/api/next_api_changes/
Release notes conform with instructions innext_whats_new/README.rst ornext_api_changes/README.rst

Reset _transformSet in Artist.remove

10dc32e

github-actionsbot reviewed

Feb 12, 2023

View reviewed changes

Copy link

github-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping@matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

Immediateduck approved these changes

Feb 20, 2023

View reviewed changes

Copy link

Member

tacaswell commentedFeb 20, 2023

I am more in favor of preventing re-adding artists (see#24626) because I suspect that this is one of a bunch of connections that are not being properly cleaned up.

tacaswell added the status: needs tests label

Feb 20, 2023

Copy link

Member

melissawm commentedMar 29, 2023

I am guessing from@tacaswell's comment that tests are not all that is needed here, but may be a good starting point.@komoto48g if you need help with adding the tests, let us know. Here are the Matplotlib testing guidelines:https://matplotlib.org/devdocs/devel/testing.html