Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

DOC: document fmt_xdata, fmt_ydata, and fmt_zdata#25187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open
tacaswell wants to merge3 commits intomatplotlib:main
base:main
Choose a base branch
Loading
fromtacaswell:doc/fmt_xydata

Conversation

tacaswell
Copy link
Member

PR Summary

Closes#9593

This documents the exact call chain so we can leave the monkey patching route implicit ;)

@tacaswelltacaswell added this to thev3.8.0 milestoneFeb 9, 2023
@oscargus
Copy link
Member

oscargus commentedFeb 10, 2023
edited
Loading

Makes sense to add the same to

# func used to format z -- fall back on major formatters
self.fmt_zdata=None

?

This may just as well go in 3.7? (I guess it would if there was a 3.7-doc? Edit: no, not in 3.7-doc as it also changes the lib-files, but still...)

@ksunden
Copy link
Member

Do we want to get this in prior 3.7.1, which we are looking to tag today?

@QuLogicQuLogic modified the milestones:v3.7.1,v3.7.2Mar 4, 2023
@tacaswelltacaswell changed the titleDOC: document fmt_xdata and fmt_ydataDOC: document fmt_xdata, fmt_ydata, and fmt_zdataMar 31, 2023
@oscargus
Copy link
Member

Just thought that I'd highlight#17286 as it is sort of related to this. At least the suggestion to rename this attribute and/or have setters/getters for it. Doesn't have to be a show stopper for this PR though.

@QuLogicQuLogic modified the milestones:v3.7.2,v3.7.3Jul 5, 2023
@QuLogicQuLogic modified the milestones:v3.7.3,v3.8-docSep 6, 2023
@story645story645 modified the milestones:v3.8-doc,v3.9-docJul 8, 2024
@rcomer
Copy link
Member

If I’m not mistaken, this is the answer tohttps://discourse.matplotlib.org/t/toolbar-parameters-in-show/25908/2

@github-actionsgithub-actionsbot added topic: mplot3d topic: axes Documentation: user guidefiles in galleries/users_explain or doc/users Documentation: APIfiles in lib/ and doc/api labelsMay 16, 2025
@tacaswelltacaswell modified the milestones:v3.10-doc,v3.11.0May 16, 2025
@tacaswell
Copy link
MemberAuthor

This can't get pulled back to the doc branch (it touches library code).

Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>
@rcomer
Copy link
Member

Recently we have documented other attributes using class level type hints (and we did backport one of these):#29965#28825

Would it make sense to do that here too?

@timhoffm
Copy link
Member

I'm a bit torn how to do this properly. The fundamental issue is that attributes are a dynamic concept and it's hard to attach meta information to them. Actually I don't like either approach: Class level type annotations are a bit awkward because we have otherwise pushed all typing to the stubs. OTOH I also don't like to create class attributes for documentation when we actually have instance attributes.

If I have to choose between those, I'd go for the type annotations, but YMMV.

@tacaswell
Copy link
MemberAuthor

If we have two other instances of using the typing style and@timhoffm prefers it, go with that method!

rcomer reacted with thumbs up emoji

@rcomer
Copy link
Member

Oh it seems it doesn't work for 3D. Is that because we have not typed the module more generally?

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic left review comments

@anntzeranntzeranntzer left review comments

@oscargusoscargusoscargus left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Documentation: APIfiles in lib/ and doc/apiDocumentation: user guidefiles in galleries/users_explain or doc/usersDocumentationtopic: axestopic: mplot3d
Projects
None yet
Milestone
v3.11.0
Development

Successfully merging this pull request may close these issues.

DOC: need discoverable documentation for Axes.fmt_xdata
9 participants
@tacaswell@oscargus@ksunden@rcomer@timhoffm@QuLogic@anntzer@story645@jklymak

[8]ページ先頭

©2009-2025 Movatter.jp