Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Disconnect SubplotTool destroyer callback on tool_fig close#25158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

richardsheridan
Copy link
Contributor

PR Summary

Fixes#24395.

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (andpytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a.. versionadded:: directive in the docstring and documented indoc/users/next_whats_new/
  • API changes are marked with a.. versionchanged:: directive in the docstring and documented indoc/api/next_api_changes/
  • Release notes conform with instructions innext_whats_new/README.rst ornext_api_changes/README.rst

@tacaswell
Copy link
Member

For those following at home the problem sequence is:

  • make (tk) figure
  • open the parameter adjustment window (this adds a callback to close child window when the main window is closed)
  • close the parameter adjustment window
  • close the main window (which complains it can not close the already closed parameter window)

The fix is to remove the callback that closes the parameter window when the parameter window is closed.

@tacaswelltacaswell added this to thev3.7.0 milestoneFeb 6, 2023
@ksundenksunden merged commit5eb3988 intomatplotlib:mainFeb 6, 2023
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestFeb 6, 2023
@richardsheridanrichardsheridan deleted the 24395-any-resizing-of-the-plot-after-pltshow-results-in-an-error-when-closing-the-window branchFebruary 6, 2023 15:53
ksunden added a commit that referenced this pull requestFeb 7, 2023
…158-on-v3.7.xBackport PR#25158 on branch v3.7.x (Disconnect SubplotTool destroyer callback on tool_fig close)
@ksundenksunden mentioned this pull requestFeb 20, 2023
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

@ksundenksundenksunden approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging this pull request may close these issues.

Any resizing of the plot after plt.show results in an error when closing the window
3 participants
@richardsheridan@tacaswell@ksunden
[8]ページ先頭
©2009-2025 Movatter.jp