Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

FIX: improve CL description and remove constrained_layout text#25144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
rcomer merged 1 commit intomatplotlib:mainfromjklymak:doc-improve-CL-desc
Feb 8, 2023

Conversation

jklymak
Copy link
Member

PR Summary

Small changes to the opening paragraphs of Constrained layout tutorial. Also stopped referring to it asconstrained_layout since we really want people to uselayout='constrained'. Improved some cross-links

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (andpytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a.. versionadded:: directive in the docstring and documented indoc/users/next_whats_new/
  • API changes are marked with a.. versionchanged:: directive in the docstring and documented indoc/api/next_api_changes/
  • Release notes conform with instructions innext_whats_new/README.rst ornext_api_changes/README.rst

@jklymakjklymakforce-pushed thedoc-improve-CL-desc branch 3 times, most recently from1558bbc to4745eacCompareFebruary 3, 2023 17:45
Copy link
Member

@rcomerrcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Nice improvement to the prose.

I spotted a couple of lines with an extra “#”, which look odd in the rendered docs so might be good to fix while you’re in there.

# # ``layout="constrained"`` keyword argument will do the adjusting
# # automatically.

Your commit message is unusually terse, which is not a big deal, but I suspect not intentional.

jklymak reacted with thumbs up emoji
@jklymakjklymakforce-pushed thedoc-improve-CL-desc branch 2 times, most recently from6df7706 to03f1f03CompareFebruary 5, 2023 00:12
@jklymakjklymakforce-pushed thedoc-improve-CL-desc branch 2 times, most recently from9c1d260 tocdf55c0CompareFebruary 5, 2023 21:19
Copy link
Member

@timhoffmtimhoffm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I suggest to pick up@rcomer's comment:#25144 (review)

But that can also be done in a followup-PR if you don't have capacity. Either way, feel free to self-merge.

@jklymak
Copy link
MemberAuthor

Sorry, I missed that change

@jklymak
Copy link
MemberAuthor

@rcomer is this OK w/ you?

@timhoffm
Copy link
Member

The double # in lines 81/82 are still there.

@jklymak
Copy link
MemberAuthor

🐑

@rcomerrcomer merged commit29dcb5c intomatplotlib:mainFeb 8, 2023
@rcomer
Copy link
Member

Ooops, forgot to pick a milestone. Should this be backported?

@jklymak
Copy link
MemberAuthor

@meeseeksdev backport to v3.7.x

@jklymakjklymak deleted the doc-improve-CL-desc branchFebruary 8, 2023 14:55
@lumberbot-app
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.7.xgit pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 29dcb5c1e68735e7896ebef8cd7114fd9a133d7f
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #25144: FIX: improve CL description and remove constrained_layout text'
  1. Push to a named branch:
git push YOURFORK v3.7.x:auto-backport-of-pr-25144-on-v3.7.x
  1. Create a PR against branch v3.7.x, I would have named this PR:

"Backport PR#25144 on branch v3.7.x (FIX: improve CL description and remove constrained_layout text)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove theStill Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free tosuggest an improvement.

@jklymak
Copy link
MemberAuthor

Bah, not worth a manual backport ;-)

rcomer reacted with thumbs up emojircomer reacted with eyes emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@timhoffmtimhoffmtimhoffm approved these changes

@rcomerrcomerrcomer approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.8.0
Development

Successfully merging this pull request may close these issues.

3 participants
@jklymak@timhoffm@rcomer
[8]ページ先頭
©2009-2025 Movatter.jp