Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
FIX: fully invalidate TransformWrapper parents before swapping#25126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
The issue is that TransformedPath only regenerates its cache for changes to thenon-affine part of the transform. When TransformWrapper for tranScale changesfrom log -> linear the non-affine part of the log transform is still cached,but when the transforms are invalidated after switching to linear theinvalidation only reports changing the affine part so the cache inTransformedPath escapes being updated (nulled out in this case) and when were-draw with linear is drawing the line off screen (or at least clipped).This change invalidates all of the parents before changing the internals ofTransformWrapper before we switch it which will cause the non-affine part to becorrectly recomputed the next time we need it.closesmatplotlib#25124
also, like 2 hours of debugging to change 1 line of code 🤣 |
ksunden approved these changesFeb 1, 2023
anntzer approved these changesFeb 2, 2023
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestFeb 2, 2023
…parents before swapping
tacaswell added a commit that referenced this pull requestFeb 3, 2023
…126-on-v3.7.xBackport PR#25126 on branch v3.7.x (FIX: fully invalidate TransformWrapper parents before swapping)
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
The issue is that TransformedPath only regenerates its cache for changes to the non-affine part of the transform. When TransformWrapper for tranScale changes from log -> linear the non-affine part of the log transform is still cached, but when the transforms are invalidated after switching to linear the invalidation only reports changing the affine part so the cache in TransformedPath escapes being updated (nulled out in this case) and when we re-draw with linear is drawing the line off screen (or at least clipped).
This change invalidates all of the parents before changing the internals of TransformWrapper before we switch it which will cause the non-affine part to be correctly recomputed the next time we need it.
closes#25124
PR Checklist
Documentation and Tests
pytestpasses)