Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Consistently document shapes as (M, N), not MxN.#25120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tacaswell merged 1 commit intomatplotlib:mainfromanntzer:mxn
Feb 1, 2023

Conversation

anntzer
Copy link
Contributor

We already mostly use "(M, N)", but there were still quite a few instances of "MxN". Also add a helper to generate the error messages in extensions.

PR Summary

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (andpytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a.. versionadded:: directive in the docstring and documented indoc/users/next_whats_new/
  • API changes are marked with a.. versionchanged:: directive in the docstring and documented indoc/api/next_api_changes/
  • Release notes conform with instructions innext_whats_new/README.rst ornext_api_changes/README.rst

Copy link
Member

@story645story645 left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Comments are take or leave/can self merge or tell me to merge
ETA: forgot it code and needs 2 reviews 🤦‍♀️

We already mostly use "(M, N)", but there were still quite a fewinstances of "MxN".  Also add a helper to generate the error messages inextensions.
@tacaswelltacaswell merged commitf3938be intomatplotlib:mainFeb 1, 2023
@anntzeranntzer deleted the mxn branchFebruary 1, 2023 17:17
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

@story645story645story645 approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.8.0
Development

Successfully merging this pull request may close these issues.

3 participants
@anntzer@tacaswell@story645
[8]ページ先頭
©2009-2025 Movatter.jp