Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Stop recommendingncol in legend examples#25110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ksunden merged 1 commit intomatplotlib:mainfromeerovaher:recommend-ncols
Jan 30, 2023

Conversation

eerovaher
Copy link
Contributor

PR Summary

Since958e329 the preferred keyword for controlling the number of columns in a legend isncols. However,

$git grep ncol= a30c0b13386ca9469ffcfed5fa24fd21aaba49c5# current main

reveals several uses of the old keyword. This pull request replaces most of them with the new recommendedncols, but three uses ofncol should remain in place:

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (andpytest passes)
  • [N/A] Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • [N/A] New plotting related features are documented with examples.

Release Notes

  • [N/A] New features are marked with a.. versionadded:: directive in the docstring and documented indoc/users/next_whats_new/
  • [N/A] API changes are marked with a.. versionchanged:: directive in the docstring and documented indoc/api/next_api_changes/
  • [N/A] Release notes conform with instructions innext_whats_new/README.rst ornext_api_changes/README.rst

Since958e329 the preferred keyword forcontrolling the number of columns in a legend is `ncols`, but some codeexamples have still been using `ncol`.
Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping@matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

Copy link
Member

@rcomerrcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks@eerovaher! I think we just need to wait for the CI to pass…

Copy link
Member

@ksundenksunden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

rerunning tests which failed for seemingly unrelated reasons (macos subprocess timeout, though test_blit, not the most common test_interactive)

Anyone can merge on green CI

@ksundenksunden added this to thev3.7.0 milestoneJan 30, 2023
@ksundenksunden merged commita38681c intomatplotlib:mainJan 30, 2023
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestJan 30, 2023
jklymak added a commit that referenced this pull requestJan 31, 2023
…110-on-v3.7.xBackport PR#25110 on branch v3.7.x (Stop recommending `ncol` in legend examples)
@eerovahereerovaher deleted the recommend-ncols branchJanuary 31, 2023 00:14
@rcomer
Copy link
Member

Thank you for submitting your first PR to Matplotlib@eerovaher. We hope to hear from you again.

eerovaher reacted with hooray emoji

@ksundenksunden mentioned this pull requestFeb 20, 2023
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@ksundenksundenksunden approved these changes

@rcomerrcomerrcomer approved these changes

Assignees
No one assigned
Projects
Milestone
v3.7.0
Development

Successfully merging this pull request may close these issues.

3 participants
@eerovaher@rcomer@ksunden

[8]ページ先頭

©2009-2025 Movatter.jp