Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix FigureCanvasTkAgg memory leak via weakrefs#25097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Conversation

richardsheridan
Copy link
Contributor

PR Summary

Fixes#24820

May be worth checking if the memory leak tests can be tightened.

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (andpytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a.. versionadded:: directive in the docstring and documented indoc/users/next_whats_new/
  • API changes are marked with a.. versionchanged:: directive in the docstring and documented indoc/api/next_api_changes/
  • Release notes conform with instructions innext_whats_new/README.rst ornext_api_changes/README.rst

@tacaswelltacaswell added this to thev3.7.0 milestoneJan 27, 2023
@tacaswell
Copy link
Member

I think it is worth the risk to backport memory-leak fixes.

@tacaswell
Copy link
Member

The flake8 is understood and fixed else where already.

@richardsheridan
Copy link
ContributorAuthor

This could lead to user breakage since things that were once immortal are now possibly short lived, just like in the original issue.

@richardsheridan
Copy link
ContributorAuthor

Maybe that was a hasty comment. They should live until someone callsdestroy oncanvas.get_tk_widget() or its parent, which should be reasonably predictable.

@ksunden
Copy link
Member

Okay, having convinced myself that these changeswork I think it seems fine.

@richardsheridan are you still thinking that things may betoo short lived, or was that last comment pretty convinced it is okay?

@richardsheridan
Copy link
ContributorAuthor

I'm satisfied that those binds won't be released too early from any practical user perspective.

@ksundenksunden merged commit472ebaa intomatplotlib:mainFeb 7, 2023
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestFeb 7, 2023
@richardsheridanrichardsheridan deleted the 24820-figurecanvastkagg-memory-leak branchFebruary 7, 2023 17:40
@ksundenksunden mentioned this pull requestFeb 20, 2023
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ksundenksundenksunden left review comments

@tacaswelltacaswelltacaswell approved these changes

Assignees
No one assigned
Labels
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging this pull request may close these issues.

FigureCanvasTkAgg memory leak
4 participants
@richardsheridan@tacaswell@ksunden@QuLogic
[8]ページ先頭
©2009-2025 Movatter.jp