Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

added a note to avoid f-strings in logging#25081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
jklymak merged 5 commits intomatplotlib:mainfrommuddi900:add/doc-note-fstrings
Mar 6, 2023
Merged

added a note to avoid f-strings in logging#25081

jklymak merged 5 commits intomatplotlib:mainfrommuddi900:add/doc-note-fstrings
Mar 6, 2023

Conversation

muddi900
Copy link
Contributor

PR Summary

As per#25080, a note has been added to thecontributing.rst

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (andpytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a.. versionadded:: directive in the docstring and documented indoc/users/next_whats_new/
  • API changes are marked with a.. versionchanged:: directive in the docstring and documented indoc/api/next_api_changes/
  • Release notes conform with instructions innext_whats_new/README.rst ornext_api_changes/README.rst

@tacaswell
Copy link
Member

@muddi900 Would you also be willing to add an example of how itshould be done to the examples?

It is not just fstrings, it is any "pre-computed" formatting that is the problem.

@muddi900
Copy link
ContributorAuthor

I'll ammend ot on the next day or so.

@jklymakjklymak marked this pull request as draftJanuary 26, 2023 02:11
@tacaswelltacaswell modified the milestone:v3.8.0Jan 26, 2023
@QuLogic
Copy link
Member

Is this complete? Please mark the PR as Ready for review if so.

@muddi900muddi900 marked this pull request as ready for reviewFebruary 22, 2023 04:55
@jklymak
Copy link
Member

You are failing a check inpre-commit.ci.

muddi900and others added3 commitsFebruary 27, 2023 06:53
added code blocks of examples and changed to pre-computedfixed code-block formattingMore gramar and format fixes
Co-authored-by: Jody Klymak <jklymak@gmail.com>
Co-authored-by: Jody Klymak <jklymak@gmail.com>
@rcomer
Copy link
Member

pre-commit.ci autofix

pre-commit-ci[bot] reacted with rocket emoji

@rcomer
Copy link
Member

Docs build has now passed and the section looks likethis.

@jklymakjklymak merged commitc0eb43e intomatplotlib:mainMar 6, 2023
@jklymak
Copy link
Member

Thanks@muddi900 !

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell left review comments

@jklymakjklymakjklymak left review comments

@oscargusoscargusoscargus left review comments

@story645story645story645 approved these changes

Assignees
No one assigned
Projects
Milestone
v3.8.0
Development

Successfully merging this pull request may close these issues.

Add note in contrib guide admonishing against use of f strings in logs
7 participants
@muddi900@tacaswell@QuLogic@jklymak@rcomer@story645@oscargus
[8]ページ先頭
©2009-2025 Movatter.jp