Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Updated WebAgg JS to check and send request over wss if using HTTPS#25039

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ksunden merged 1 commit intomatplotlib:mainfromwhyvra:fix/update_webagg_js
Jan 25, 2023
Merged

Updated WebAgg JS to check and send request over wss if using HTTPS#25039

ksunden merged 1 commit intomatplotlib:mainfromwhyvra:fix/update_webagg_js
Jan 25, 2023

Conversation

whyvra
Copy link
Contributor

PR Summary

Added a small change to the JavaScript for the WebAgg backend. The added JavaScript code will check the protocol and updated the websocket uri towss: ifhttps: is being used.

This is to fix an issue with matplotlib running behind a reverse proxy that adds HTTPS and secure HTTP headers like HSTS. The connection to the insecure websocket i.e.ws: is blocked by the browser with the message:

Mixed Content: The page at 'https:/<some_website>/' was loaded over HTTPS,  but attempted to connect to the insecure WebSocket endpoint 'ws://<some_website>/1/ws'. This request has been blocked; this endpoint must be available over WSS.

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (andpytest passes) N/A
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error). N/A
  • New plotting related features are documented with examples. N/A

Release Notes

  • New features are marked with a.. versionadded:: directive in the docstring and documented indoc/users/next_whats_new/ N/A
  • API changes are marked with a.. versionchanged:: directive in the docstring and documented indoc/api/next_api_changes/ N/A
  • Release notes conform with instructions innext_whats_new/README.rst ornext_api_changes/README.rst N/A

Not sure whether or not I need to update any documentation, so please let me know if I do.

Thank you

Copy link

@github-actionsgithub-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping@matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

@tacaswell
Copy link
Member

On its face this looks reasonable to me, but I have no idea how to test it.

@rcomerrcomer linked an issueJan 20, 2023 that may beclosed by this pull request
@whyvra
Copy link
ContributorAuthor

@tacaswell I created a repo that uses a Docker image to reproduce the issue and test the updated JS.

You can find it herehttps://github.com/whyvra/matplotlib-sample.

Please let me know if you need more info on anything.

Cheers

Copy link
Member

@QuLogicQuLogic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I confirmed this worked with a Caddy reverse proxy.

@QuLogicQuLogic added this to thev3.7.0 milestoneJan 21, 2023
@ksundenksunden merged commit66f7956 intomatplotlib:mainJan 25, 2023
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestJan 25, 2023
QuLogic added a commit that referenced this pull requestJan 25, 2023
…039-on-v3.7.xBackport PR#25039 on branch v3.7.x (Updated WebAgg JS to check and send request over wss if using HTTPS)
@ksundenksunden mentioned this pull requestFeb 20, 2023
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@github-actionsgithub-actions[bot]github-actions[bot] left review comments

@QuLogicQuLogicQuLogic approved these changes

@ksundenksundenksunden approved these changes

Assignees
No one assigned
Projects
Milestone
v3.7.0
Development

Successfully merging this pull request may close these issues.

[Bug]: Request to insecure websocket endpoint is blocked by browser
4 participants
@whyvra@tacaswell@QuLogic@ksunden

[8]ページ先頭

©2009-2025 Movatter.jp