Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
separate out folders in gallery ordering#25028
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
All optional stylistic comments.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This is an improvement.
I still feel it is very hard to discover where this order gets set. I like@QuLogic idea of having something in the README.rst that gets scraped.
Uh oh!
There was an error while loading.Please reload this page.
Separates each gallery ordering into its own list to make it a little cleaner to find/order each gallery. Should maybe be a conf file but this was a quick proof of concept inspired by ordering being a pain in#24746 (comment)
ETA: I like@QuLogic's idea#24746 (comment) of putting the ordering in each readme better but don't really have the time to implement that...I think it would basically be populate these lists w/ the contents of those readmes