Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Simplify "artist reference" example.#25018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Perhaps link to the patch collection example to keep some of the cross linking? We don't do a good enough job of cross linking things so it seems a shame to drop an opportunity here. |
In particular, add each artist directly to its own axes, instead ofshifting each of them by some offset and grouping all of them togetherin a PatchCollection. Note that this makes the example no longershowcase the use of PatchCollection, but at least based on the docstringthat was not the intent of the example anyways, and PatchCollection isshowcased elsewhere (in the patch_collection.py example, in particular).
sure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks - ping for a merge if I forget - I'll double check that it all looks OK.
…018-on-v3.7.xBackport PR#25018 on branch v3.7.x (Simplify "artist reference" example.)
In particular, add each artist directly to its own axes, instead of shifting each of them by some offset and grouping all of them together in a PatchCollection. Note that this makes the example no longer showcase the use of PatchCollection, but at least based on the docstring that was not the intent of the example anyways, and PatchCollection is showcased elsewhere (in the patch_collection.py example, in particular).
PR Summary
PR Checklist
Documentation and Tests
pytestpasses)Release Notes
.. versionadded::directive in the docstring and documented indoc/users/next_whats_new/.. versionchanged::directive in the docstring and documented indoc/api/next_api_changes/next_whats_new/README.rstornext_api_changes/README.rst