Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Expire deprecations from 3.6#24984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ksunden merged 35 commits intomatplotlib:mainfromoscargus:pickradius
Mar 8, 2023
Merged

Conversation

oscargus
Copy link
Member

@oscargusoscargus commentedJan 14, 2023•
edited
Loading

PR Summary

Not all, but most (all?) of the ones I understood (quite) easily...

Split into multiple commits for somewhat sensible commit messages. Will add an api-change note.

The first commit also improves the argument checking of(set_)pickradius slightly.

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (andpytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a.. versionadded:: directive in the docstring and documented indoc/users/next_whats_new/
  • API changes are marked with a.. versionchanged:: directive in the docstring and documented indoc/api/next_api_changes/
  • Release notes conform with instructions innext_whats_new/README.rst ornext_api_changes/README.rst

@oscargusoscargus added this to thev3.8.0 milestoneJan 14, 2023
@oscargusoscargusforce-pushed thepickradius branch 4 times, most recently fromdbb0c54 tof97e5f5CompareJanuary 14, 2023 15:14
@@ -575,7 +575,7 @@ default. The default face color is now ``'C0'`` instead of ``'b'``.
ax_bottom.set_ylim(0, .75)
ax_bottom.add_artist(mpatches.Rectangle(grid[1] - [0.025, 0.05],
0.05, 0.1))
ax_bottom.add_artist(mpatches.RegularPolygon(grid[3], 5, 0.1))
Copy link
MemberAuthor

@oscargusoscargusJan 14, 2023•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

One would have expected this to warn earlier?

Edit: it did warn, but it seems like the doc-build didn't pick it up.

@efiring
Copy link
Member

Thank you for doing this. I read through the file diffs without finding any problems. I did not try to match every removal with a note in the changes/removals file, but I did notice that removals from the backends don't seem to be mentioned there.

@oscargus
Copy link
MemberAuthor

Ahh, you are correct. Well spotted!

In the 3.6 documents it was a big list of all the backend changes, but I didn't touch the interactive ones, so at the time I just skipped that for later and forgot about it...

@oscargus
Copy link
MemberAuthor

This is now added.

Note that some of the things didn't have deprecation notices in the 3.6 docs, such as positional argument renaming.

@oscargus
Copy link
MemberAuthor

Thanks@anntzer ! Should be sorted out now.

Copy link
Contributor

@anntzeranntzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

postci

Copy link
Member

@ksundenksunden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Only hard blocker is the offsetbox kw-only arg position, but also commented on collections version ofpickradius if you wish to make that consistent with some other pickradus implementations

@oscargus
Copy link
MemberAuthor

Thanks@ksunden ! Good finds!

@ksundenksunden merged commitc9bd855 intomatplotlib:mainMar 8, 2023
@oscargusoscargus deleted the pickradius branchMarch 8, 2023 22:32
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@anntzeranntzeranntzer approved these changes

@ksundenksundenksunden approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.8.0
Development

Successfully merging this pull request may close these issues.

4 participants
@oscargus@efiring@anntzer@ksunden
[8]ページ先頭
©2009-2025 Movatter.jp