NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

Let quiver retrieve X, Y from base PolyCollection.get_offsets().#24952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Draft

anntzer wants to merge1 commit intomatplotlib:main

base:main

Choose a base branch

fromanntzer:qb

Draft

Let quiver retrieve X, Y from base PolyCollection.get_offsets().#24952

anntzer wants to merge1 commit intomatplotlib:mainfromanntzer:qb

Conversation

Copy link

Contributor

anntzer commentedJan 12, 2023

... instead of additionally storing copies locally inself.X, self.Y, self.XY (for quiver),self.x, self.y (for barbs).

Then there's no reason not to also suggest set_offsets in quiver(), like it's already done in barbs().

PR Summary

PR Checklist

Documentation and Tests

Has pytest style unit tests (andpytest passes)
Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
New plotting related features are documented with examples.

Release Notes

New features are marked with a.. versionadded:: directive in the docstring and documented indoc/users/next_whats_new/
API changes are marked with a.. versionchanged:: directive in the docstring and documented indoc/api/next_api_changes/
Release notes conform with instructions innext_whats_new/README.rst ornext_api_changes/README.rst

Let quiver retrieve X, Y from base PolyCollection.get_offsets().

11e029b

... instead of additionally storing copies locally in`self.X, self.Y, self.XY` (for quiver), `self.x, self.y` (for barbs).Then there's no reason not to also suggest set_offsets in quiver(), likeit's already done in barbs().

anntzer force-pushed theqb branch fromef98721 to11e029bCompare

January 12, 2023 10:56

ianhi reviewed

Jan 12, 2023

View reviewed changes

lib/matplotlib/quiver.py

Comment on lines +451 to +453

		orientation, and color of the arrows. Locations are changed using the
		(inherited) `.PolyCollection.set_offsets` method. This method may be
		useful in animations.

Copy link

Contributor

ianhiJan 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Unfortunately I think the behavior is a little bit more complicated than than just usingset_offsets due to the interactions of UVC and XY which may be difficult for users to discover. See#22407