Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

DOC: mark mosaic as no longer provisional#24891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

Conversation

tacaswell
Copy link
Member

PR Summary

Mark mosaic as no longer provisional.

I also moved this from tutorials -> examples as this is much a how-to and "gallery" is what we have that matches the divio "how-to" best.

rcomer reacted with heart emoji
@tacaswelltacaswell added this to thev3.7.0 milestoneJan 5, 2023
@tacaswelltacaswell marked this pull request as ready for reviewJanuary 5, 2023 23:08
Co-authored-by: Jody Klymak <jklymak@gmail.com>
Copy link
Member

@jklymakjklymak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

If you search for "mosaic" on the rendered docs example page, you do not get this example showing up. I think folks wanting a quick guide as to how subplot_mosaic works will want that in the title.

story645 reacted with thumbs up emoji
Copy link
Member

@oscargusoscargus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Should there be some sort of release note for this? It may make sense for users to know that this has happened in another way than noting that the provisional note has been removed.

rcomer reacted with thumbs up emoji
@oscargus
Copy link
Member

I may argue that it is indeed a tutorial type of document here. One could possibly add an example or two, but considering the style and length of the documentation, it seems more like a tutorial than an example. But if others disagree, I will not block based on this.

rcomer reacted with thumbs up emoji

@rcomer
Copy link
Member

it seems more like a tutorial than an example

Within the tutorials, I prefer the subject categories (Colors, Text) to the basic/intermediate/advanced categories. The subject links help me navigate to the thing that I currently want to learn about, whereas I don't know the difficulty level of the thing until I've learned it. I wonder if we could make a "layouts" tutorial category for mosaic, constrained layout, tight layout and "arranging multiple Axes in a Figure". I appreciate that that is a little out of scope for this PR though.

jklymak, story645, and timhoffm reacted with thumbs up emojistory645 reacted with heart emoji

@tacaswell
Copy link
MemberAuthor

If we use the terminology fromhttps://documentation.divio.com/tutorials/ then this is not a tutorial because it is just N related examples all on one page. To riff on their cooking analogy, this is a list of every way to cook and egg not instructions on how to make a nice omelette breakfast. Under this rubric I think many of the things currently in tutorials are miss-categorized (https://matplotlib.org/stable/tutorials/introductory/lifecycle.html and maybe the image one may be the only ones that actually fit the divio definition).

Good point about the release notes, I'll add that.

@jklymak
Copy link
Member

jklymak commentedJan 6, 2023
edited
Loading

Certainly some of what we have in "tutorials" are not actual tutorials, but are long-form documentation of features and how the library works. I'd argue that 10 or 12 examples as part of a narrative of how a feature works is not really an "Example" either.

Let's open a new issue to discuss how to organize the tutorials, since this has come up a few times. Personally I wouldn't move the subplots_mosaic to Examples, but don't feel strongly about it.

EDIT: See#24900 for further discussion of "tutorials"....

@tacaswelltacaswellforce-pushed thedoc_mosaic_not_provisional branch froma27fa2b to0bc10e9CompareJanuary 7, 2023 02:50
@ksundenksunden merged commitb06433c intomatplotlib:mainJan 7, 2023
@tacaswelltacaswell deleted the doc_mosaic_not_provisional branchJanuary 7, 2023 11:29
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@jklymakjklymakjklymak approved these changes

@oscargusoscargusoscargus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging this pull request may close these issues.

5 participants
@tacaswell@oscargus@rcomer@jklymak@ksunden

[8]ページ先頭

©2009-2025 Movatter.jp