Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Show that fill_between and span_where provide similar functionalities.#24843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
rcomer merged 1 commit intomatplotlib:mainfromanntzer:fbsw
Dec 31, 2022

Conversation

anntzer
Copy link
Contributor

PR Summary

In preparation for a possible deprecation of BrokenBarHCollection (#24827), which may be a good idea.
Using axes methods is usually simpler for end users, anyways.

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (andpytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a.. versionadded:: directive in the docstring and documented indoc/users/next_whats_new/
  • API changes are marked with a.. versionchanged:: directive in the docstring and documented indoc/api/next_api_changes/
  • Release notes conform with instructions innext_whats_new/README.rst ornext_api_changes/README.rst

Copy link
Member

@rcomerrcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Definite improvement. I just have one trivial suggestion that you are welcome to ignore if you wish.

@rcomerrcomer added this to thev3.6-doc milestoneDec 31, 2022
@anntzer
Copy link
ContributorAuthor

sure, done.

rcomer reacted with thumbs up emoji

@rcomerrcomer merged commit087ca0c intomatplotlib:mainDec 31, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestDec 31, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestDec 31, 2022
ksunden added a commit that referenced this pull requestJan 1, 2023
…843-on-v3.6.xBackport PR#24843 on branch v3.6.x (Show that fill_between and span_where provide similar functionalities.)
ksunden added a commit that referenced this pull requestJan 1, 2023
…843-on-v3.6.2-docBackport PR#24843 on branch v3.6.2-doc (Show that fill_between and span_where provide similar functionalities.)
@anntzeranntzer deleted the fbsw branchJanuary 1, 2023 18:07
@QuLogic
Copy link
Member

@meeseeksdev backport to v3.7.x

@lumberbot-app
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.7.xgit pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 087ca0c615f697dc857277b0fb87657c13ee0eed
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #24843: Show that fill_between and span_where provide similar functionalities.'
  1. Push to a named branch:
git push YOURFORK v3.7.x:auto-backport-of-pr-24843-on-v3.7.x
  1. Create a PR against branch v3.7.x, I would have named this PR:

"Backport PR#24843 on branch v3.7.x (Show that fill_between and span_where provide similar functionalities.)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove theStill Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free tosuggest an improvement.

@QuLogic
Copy link
Member

OK, will do it as part of the merge myself.

@QuLogic
Copy link
Member

Actually, I misunderstood the conflict; this conflicts because it was deprecated in 3.7; there's no need to backport this PR.

@ksundenksunden mentioned this pull requestFeb 20, 2023
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@rcomerrcomerrcomer approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.6-doc
Development

Successfully merging this pull request may close these issues.

3 participants
@anntzer@QuLogic@rcomer

[8]ページ先頭

©2009-2025 Movatter.jp