Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Show that fill_between and span_where provide similar functionalities.#24843
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Definite improvement. I just have one trivial suggestion that you are welcome to ignore if you wish.
sure, done. |
…rovide similar functionalities.
…rovide similar functionalities.
…843-on-v3.6.xBackport PR#24843 on branch v3.6.x (Show that fill_between and span_where provide similar functionalities.)
…843-on-v3.6.2-docBackport PR#24843 on branch v3.6.2-doc (Show that fill_between and span_where provide similar functionalities.)
@meeseeksdev backport to v3.7.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free tosuggest an improvement. |
OK, will do it as part of the merge myself. |
Actually, I misunderstood the conflict; this conflicts because it was deprecated in 3.7; there's no need to backport this PR. |
PR Summary
In preparation for a possible deprecation of BrokenBarHCollection (#24827), which may be a good idea.
Using axes methods is usually simpler for end users, anyways.
PR Checklist
Documentation and Tests
pytest
passes)Release Notes
.. versionadded::
directive in the docstring and documented indoc/users/next_whats_new/
.. versionchanged::
directive in the docstring and documented indoc/api/next_api_changes/
next_whats_new/README.rst
ornext_api_changes/README.rst