Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

[Doc] expanded basic pie example#24812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 1 commit intomatplotlib:mainfromstory645:pie-example
Jan 20, 2023
Merged

Conversation

story645
Copy link
Member

@story645story645 commentedDec 22, 2022•
edited
Loading

added small examples of labels, autopct, colors, hatch, and distance in an attempt to scaffold up to exploding example. I also kinda really like this model of documenting the plotting methods - small isolated example of each notable keyword - so if other folks do too, this could be a way to consolidate some of the examples. It's also a style I'm seeing a lot in blog posts and social media tutorials so I think it's popular. (ETA: also is how the subplot mosaic guide is written, see24891)

Plus the section headers make the navigation really nice:

image

Pulled this out of#24470 to make reviewing easier, so this also documents thehatch keyword introduced there & therefore all the things will break until that PR is merged. Also tries to address some of#24789

@jklymak
Copy link
Member

Hard restarting the PR doesn't restart circle I guess.@story645 you will have to rebase on master to gethatch kwarg.

story645 reacted with thumbs up emoji

@jklymak
Copy link
Member

Shouldn't the title for the page change? Otherwise looks good.

@story645
Copy link
MemberAuthor

Shouldn't the title for the page change? Otherwise looks good.

To 'Bar Chart`? and what do you think about this sorta model for documenting at least plotting and other common methods? I'm honestly thinking of it as a sorta visual API doc, b/c a major advantage of being a viz library is that we can visualize a lot of the API. It ends up inherently being a bit of a how to too, but I think it's one way to address the problem of inconsistent naming of things across visualization libraries.

@jklymak
Copy link
Member

"Pie charts"?

@story645
Copy link
MemberAuthor

"Pie charts"?

🤦‍♀️ clearly I'm sleep deprived

Copy link
Member

@dstansbydstansby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Some minor non-blocking suggestions, but much improved over the previous version!

@story645story645force-pushed thepie-example branch 2 times, most recently from11d528d to00cff21CompareJanuary 12, 2023 23:24
@ksunden
Copy link
Member

circle is caught because it's using the pre-merge config (which specifies python 3.8) but post-merge code (and setup.py, which specifies 3.9 as the minimum) Should be resolved with a rebase, which will have the up to date circle config.

story645 reacted with thumbs up emoji

@story645story645force-pushed thepie-example branch 2 times, most recently from58e3f79 to9d04a5cCompareJanuary 19, 2023 20:23
@QuLogic
Copy link
Member

You have some######... that should be replaced by# %% now.

added small examples of labels,autopct, colors, hatch, and distance in an attempt to scaffold up toexploding exampleaddresses some ofmatplotlib#24789Co-authored-by: Elliott Sales de Andrade <quantum.analyst@gmail.com>Co-authored-by: David Stansby <dstansby@gmail.com>
@QuLogicQuLogic merged commit3309b15 intomatplotlib:mainJan 20, 2023
@lumberbot-app
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.7.xgit pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 3309b152f56e06e1ddc0d1ab91adc245a1a8c1a5
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #24812: [Doc] expanded basic pie example'
  1. Push to a named branch:
git push YOURFORK v3.7.x:auto-backport-of-pr-24812-on-v3.7.x
  1. Create a PR against branch v3.7.x, I would have named this PR:

"Backport PR#24812 on branch v3.7.x ([Doc] expanded basic pie example)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove theStill Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free tosuggest an improvement.

@QuLogic
Copy link
Member

Oh right, the# %% change conflicts now; up to you if you want to backport.

story645 pushed a commit to story645/matplotlib that referenced this pull requestJan 20, 2023
story645 pushed a commit to story645/matplotlib that referenced this pull requestJan 20, 2023
@story645story645 deleted the pie-example branchJanuary 20, 2023 02:40
@story645
Copy link
MemberAuthor

#25034

QuLogic added a commit that referenced this pull requestJan 20, 2023
…v3.7.xBackport PR#24812 on branch v3.7.x ([Doc] expanded basic pie example)
@ksundenksunden mentioned this pull requestFeb 20, 2023
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic left review comments

@dstansbydstansbydstansby approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging this pull request may close these issues.

5 participants
@story645@jklymak@ksunden@QuLogic@dstansby
[8]ページ先頭
©2009-2025 Movatter.jp