Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Adjust docstrings of legend for typos, font size#24804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
As far as I can tell, fontsize is a floating point value in points thatis passed directly to legend_handler... which makes me skeptical aboutthe documentation that says it is an integer number of pixels.
A brief summary of some thoughts here:
|
If it isn't in points it probably should be in points 'cause consistency. Is there a way to test by passing the same # to this method and something that's documented as pixel and seeing if they look the same, or nah 'cause the numbers get multiplied in different ways before they hit the renderer? (I think we should maybe define a custom float type "points", but that's part of the larger internal typing discussion) |
If it is in points, then where we use it needs to become dpi aware? |
PR Summary
As far as I can tell, fontsize is a floating point value in points that
is passed directly to legend_handler... which makes me skeptical about
the documentation that says it is an integer number of pixels.
PR Checklist
Documentation and Tests
pytest
passes)Release Notes
.. versionadded::
directive in the docstring and documented indoc/users/next_whats_new/
.. versionchanged::
directive in the docstring and documented indoc/api/next_api_changes/
next_whats_new/README.rst
ornext_api_changes/README.rst