Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork8.1k
DOC: restore SHA to footer#24781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
tacaswell commentedDec 20, 2022
This will also require a pin forward on the version of mpl-sphinx-theme we require to build the docs. |
QuLogic commentedDec 20, 2022
There is no pin on |
tacaswell commentedJan 5, 2023
ef7667d to5744893CompareQuLogic commentedJan 6, 2023 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
5744893 tocddb0f1Comparetacaswell commentedFeb 10, 2023
I am in favor of leaving the CSS tweaking for later. |
jklymak commentedFeb 10, 2023
Feel free to self-merge if mpl-sphinx-theme is already at 3.7 |
tacaswell commentedFeb 10, 2023
it is in a funny state (due to branch protections I could not push the version bumping commit to main but Icould push the tag, will fix that soon), but there is a release on pypi. |
tacaswell commentedFeb 10, 2023
manually cancelled the appevyor to unblock it for other PRs. |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free tosuggest an improvement. |
tacaswell commentedFeb 10, 2023
Will backport this as part of#25194 . |
DOC: restore SHA to footer(cherry picked from commit73909bc)
DOC: restore SHA to footer(cherry picked from commit73909bc)
DOC: restore SHA to footer(cherry picked from commit73909bc)
DOC: restore SHA to footer(cherry picked from commit73909bc)
ksunden commentedFeb 14, 2023
Backport included in 3.7.0 final preparation |


PR Summary
Depends onmatplotlib/mpl-sphinx-theme#54 being merged.
We used to include the exact commit used to build the docs in the footer (seehttps://matplotlib.org/3.4.3/index.html) however that got lost as part of the move to mpl-sphinx-theme. This adds the option to put this in the footer again.