Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

DOC: restore SHA to footer#24781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ksunden merged 2 commits intomatplotlib:mainfromtacaswell:mnt/restore_doc_sha
Feb 10, 2023

Conversation

@tacaswell
Copy link
Member

PR Summary

Depends onmatplotlib/mpl-sphinx-theme#54 being merged.

We used to include the exact commit used to build the docs in the footer (seehttps://matplotlib.org/3.4.3/index.html) however that got lost as part of the move to mpl-sphinx-theme. This adds the option to put this in the footer again.

@tacaswell
Copy link
MemberAuthor

This will also require a pin forward on the version of mpl-sphinx-theme we require to build the docs.

@QuLogic
Copy link
Member

There is no pin onmain, only the release branch.

@tacaswell
Copy link
MemberAuthor

image

@QuLogic
Copy link
Member

QuLogic commentedJan 6, 2023
edited
Loading

With a small bit of CSS:

.bd-footer__inner {display: flex;flex-wrap: wrap;}.footer-item {margin:00.5em;}.footer-item:first-child {width:100%;}

we can get it together like before:
image

which I'm not sure if that should end up inmpl-sphinx-theme?

@ksundenksunden added the Documentation: websitelayout/behavior/styling changes labelJan 25, 2023
@tacaswelltacaswell marked this pull request as ready for reviewFebruary 10, 2023 19:05
@tacaswell
Copy link
MemberAuthor

I am in favor of leaving the CSS tweaking for later.

@jklymak
Copy link
Member

Feel free to self-merge if mpl-sphinx-theme is already at 3.7

@tacaswell
Copy link
MemberAuthor

Feel free to self-merge if mpl-sphinx-theme is already at 3.7

it is in a funny state (due to branch protections I could not push the version bumping commit to main but Icould push the tag, will fix that soon), but there is a release on pypi.

@tacaswell
Copy link
MemberAuthor

manually cancelled the appevyor to unblock it for other PRs.

@ksundenksunden merged commit73909bc intomatplotlib:mainFeb 10, 2023
@lumberbot-app
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.7.xgit pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 73909bcb408886a22e2b84581d6b9e6d9907c813
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #24781: DOC: restore SHA to footer'
  1. Push to a named branch:
git push YOURFORK v3.7.x:auto-backport-of-pr-24781-on-v3.7.x
  1. Create a PR against branch v3.7.x, I would have named this PR:

"Backport PR#24781 on branch v3.7.x (DOC: restore SHA to footer)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove theStill Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free tosuggest an improvement.

@tacaswelltacaswell deleted the mnt/restore_doc_sha branchFebruary 10, 2023 22:08
@tacaswell
Copy link
MemberAuthor

Will backport this as part of#25194 .

tacaswell pushed a commit to tacaswell/matplotlib that referenced this pull requestFeb 10, 2023
DOC: restore SHA to footer(cherry picked from commit73909bc)
tacaswell pushed a commit to tacaswell/matplotlib that referenced this pull requestFeb 10, 2023
DOC: restore SHA to footer(cherry picked from commit73909bc)
ksunden added a commit to tacaswell/matplotlib that referenced this pull requestFeb 13, 2023
DOC: restore SHA to footer(cherry picked from commit73909bc)
ksunden added a commit to tacaswell/matplotlib that referenced this pull requestFeb 13, 2023
DOC: restore SHA to footer(cherry picked from commit73909bc)
@ksunden
Copy link
Member

Backport included in 3.7.0 final preparation

@ksundenksunden mentioned this pull requestFeb 20, 2023
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@jklymakjklymakjklymak approved these changes

Assignees

No one assigned

Labels

Documentation: websitelayout/behavior/styling changes

Projects

None yet

Milestone

v3.7.0

Development

Successfully merging this pull request may close these issues.

4 participants

@tacaswell@QuLogic@jklymak@ksunden

[8]ページ先頭

©2009-2025 Movatter.jp