Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Allow polar scales where zero is not in valid interval#24763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
QuLogic merged 1 commit intomatplotlib:mainfromdstansby:polar-nonsingular
Dec 31, 2022

Conversation

dstansby
Copy link
Member

@dstansbydstansby commentedDec 18, 2022
edited
Loading

PR Summary

This allows scales to be set on polar Axes where 0 is not in the valid scale limits (e.g. a log scale falls into this category). Because there is some special casing in polar radial view limits that tries to include zero all the time, I didn't want to break this, so instead I've gone for the most general check of running the interval [0, 1] through the scale'slimit_range_for_scale method, and checking if a 0 comes out. If it doesn't, the deafult behaviour of the locator is used to set the view limits and nonsingular values.

Goes part way to fixing#24383

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (andpytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a.. versionadded:: directive in the docstring and documented indoc/users/next_whats_new/
  • API changes are marked with a.. versionchanged:: directive in the docstring and documented indoc/api/next_api_changes/
  • Release notes conform with instructions innext_whats_new/README.rst ornext_api_changes/README.rst

@dstansbydstansby marked this pull request as draftDecember 18, 2022 13:02
@dstansbydstansby changed the titleRemove special nonsingular casing in RadialLocatorAllow polar scales where zero is not in valid intervalDec 20, 2022
@dstansbydstansby marked this pull request as ready for reviewDecember 20, 2022 18:39
@QuLogicQuLogic merged commitfc5d316 intomatplotlib:mainDec 31, 2022
@QuLogicQuLogic added this to thev3.7.0 milestoneDec 31, 2022
@dstansbydstansby deleted the polar-nonsingular branchDecember 31, 2022 11:03
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

@oscargusoscargusoscargus approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging this pull request may close these issues.

3 participants
@dstansby@QuLogic@oscargus

[8]ページ先頭

©2009-2025 Movatter.jp