Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

MEP12: Example clean-up for reference#2474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
pelson merged 21 commits intomatplotlib:masterfromtonysyu:canonical-example-refactor
Jan 14, 2014

Conversation

tonysyu
Copy link
Contributor

This PR is meant as a reference for clean-ups that should take place as part of the Gallery clean ups outlined in MEP12.

The original example was trying to do too much in one place.
Remove plot of exact PDF since this is already demoed in another example.
The example linked in backend_driver was broken when examples weresplit up and renamed/moved.
@NelleV
Copy link
Member

That looks good to me. Are we sure that there are no explicit links to this example in the documentation ?

Also, can you squash some of those commits. That's a long list for the size of the patch :)

Else, I'm 👍

@WeatherGod
Copy link
Member

I am against squashing this. That list is an excellent bulletted list of
the kinds of changes that are needed. And it makes it very easy to
reference an example of each.

@NelleV
Copy link
Member

Squashing commits doesn't mean removing the content of the commit messages.

@tonysyu
Copy link
ContributorAuthor

Actually, I wanted to be as specific as possible with each commit. There were a few I might have wanted to group together, but for the most part each one gives a good, isolated description of different types of changes. This is important because I use these commits as concrete examples in theMEP (which links directly to commits).

And yes, as far as I can tell, none of the docs link to this example.

@tacaswell
Copy link
Member

Is there any reason this has not been merged?

pelson added a commit that referenced this pull requestJan 14, 2014
@pelsonpelson merged commitd81498f intomatplotlib:masterJan 14, 2014
@domspaddomspad mentioned this pull requestJul 14, 2015
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.4.0
Development

Successfully merging this pull request may close these issues.

5 participants
@tonysyu@NelleV@WeatherGod@tacaswell@pelson

[8]ページ先頭

©2009-2025 Movatter.jp