Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Support masked dates#24734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
rcomer merged 1 commit intomatplotlib:mainfromoscargus:maskeddates
Dec 16, 2022
Merged

Support masked dates#24734

rcomer merged 1 commit intomatplotlib:mainfromoscargus:maskeddates
Dec 16, 2022

Conversation

oscargus
Copy link
Member

PR Summary

Related to#24732 (comment)

Now,date2num does not strip any mask information.

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (andpytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a.. versionadded:: directive in the docstring and documented indoc/users/next_whats_new/
  • API changes are marked with a.. versionchanged:: directive in the docstring and documented indoc/api/next_api_changes/
  • Release notes conform with instructions innext_whats_new/README.rst ornext_api_changes/README.rst

@oscargusoscargus marked this pull request as draftDecember 15, 2022 16:14
@oscargus
Copy link
MemberAuthor

Thanks for your good reviews@rcomer and@chahak13 !

I came up with a slightly different solution asastimezone didn't exist forMaskedConstant. Now, both paths are tested using masked dates.

chahak13 reacted with hooray emoji

@oscargusoscargus marked this pull request as ready for reviewDecember 15, 2022 20:55
@oscargusoscargus added this to thev3.7.0 milestoneDec 15, 2022
@rcomerrcomer merged commit60dd992 intomatplotlib:mainDec 16, 2022
@oscargusoscargus deleted the maskeddates branchDecember 16, 2022 13:09
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@chahak13chahak13chahak13 left review comments

@jklymakjklymakjklymak approved these changes

@rcomerrcomerrcomer approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.7.0
Development

Successfully merging this pull request may close these issues.

4 participants
@oscargus@jklymak@rcomer@chahak13
[8]ページ先頭
©2009-2025 Movatter.jp