NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

TST: Set explicit styles for image tests#24709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Draft

oscargus wants to merge1 commit intomatplotlib:main

base:main

Choose a base branch

fromoscargus:teststyles

Draft

TST: Set explicit styles for image tests#24709

oscargus wants to merge1 commit intomatplotlib:mainfromoscargus:teststyles

Conversation

Copy link

Member

oscargus commentedDec 13, 2022

PR Summary

Change all image test styles to explicit so that it is possible to change the default at some later stage.

PR Checklist

Documentation and Tests

Has pytest style unit tests (andpytest passes)
Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
New plotting related features are documented with examples.

Release Notes

New features are marked with a.. versionadded:: directive in the docstring and documented indoc/users/next_whats_new/
API changes are marked with a.. versionchanged:: directive in the docstring and documented indoc/api/next_api_changes/
Release notes conform with instructions innext_whats_new/README.rst ornext_api_changes/README.rst

oscargus added the topic: testing label

Dec 13, 2022

TST: Set explicit styles for image tests

f57e7c4

oscargus force-pushed theteststyles branch from48ec100 tof57e7c4Compare

December 13, 2022 09:14

Copy link

MemberAuthor

oscargus commentedDec 13, 2022

Turns out that these are not all, but all that was found in my IDE... I was surprised that it wasn't that many, but clearly I was wrong. Anyway, I expected to do this is steps, so this is one step.

timhoffm reviewed

Dec 13, 2022

View reviewed changes

lib/matplotlib/tests/test_agg.py

		@image_comparison(['agg_filter.png'], remove_text=True)
		# # Update style when regenerating the test image
		@image_comparison(['agg_filter.png'], remove_text=True,
		style=("classic", "_classic_test_patch"))

Copy link

Member

timhoffmDec 13, 2022•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Having this baseline + patch style combination is a bit bulky given that we write it all over the tests. I suggest to create a_classic_test style that hard-coded merges both.