NotificationsYou must be signed in to change notification settings
Fork7.9k
Star21.3k

Addresses issue #24617 adding setters/getters for Figure#24696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Closed

garveyz2 wants to merge4 commits intomatplotlib:mainfromgarveyz2:setters-getters

Closed

Addresses issue #24617 adding setters/getters for Figure#24696

garveyz2 wants to merge4 commits intomatplotlib:mainfromgarveyz2:setters-getters

Conversation

Copy link

garveyz2 commentedDec 11, 2022

PR Summary

Hello, this is my first contribution to an open-source project. This PR is to address the concerns raised in#24617. I've cherrypicked my solution from a previous PR#21549. I have mainly added setters and getters for subplot params as well as modifying the aliases for size_inches to figsize and layout_engine to layout.

PR Checklist

Documentation and Tests

Has pytest style unit tests (andpytest passes)
Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
[N/A] New plotting related features are documented with examples.

Release Notes

New features are marked with a.. versionadded:: directive in the docstring and documented indoc/users/next_whats_new/
API changes are marked with a.. versionchanged:: directive in the docstring and documented indoc/api/next_api_changes/
Release notes conform with instructions innext_whats_new/README.rst ornext_api_changes/README.rst

garveyz2 added2 commits

December 11, 2022 17:40

added getters and setters subplotparams for figure

2798e48

added tests for getters and setters for figure

c06078f

garveyz2 marked this pull request as draft

December 11, 2022 23:35

github-actionsbot reviewed

Dec 11, 2022

View reviewed changes

Copy link

github-actionsbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thank you for opening your first PR into Matplotlib!

If you have not heard from us in a while, please feel free to ping@matplotlib/developers or anyone who has commented on the PR. Most of our reviewers are volunteers and sometimes things fall through the cracks.

You can also join uson gitter for real-time discussion.

For details on testing, writing docs, and our review process, please seethe developer guide

We strive to be a welcoming and open project. Please follow ourCode of Conduct.

garveyz2 added2 commits

December 11, 2022 18:48

fixed flake8 style

119f4e7

fix lint for figure.py

2714ef9

Copy link

Member

rcomer commentedJan 13, 2023

@garveyz2 thanks for your work on this. Is it ready to be reviewed? If so you should see a "Ready for review" button which will take the "draft" status off it.

rcomer linked an issue

Jan 13, 2023

that may beclosed by this pull request

[ENH]: Add setter/getter methods for all keyword parameters to Figure.__init__#24617

Open

pmeier mentioned this pull request

Jan 17, 2023

new contributor requesting guidancepmeier/pmeier#7

Closed

rcomer added the status: orphaned PR label

Mar 11, 2023

github-actionsbot added the status: needs rebase label

Mar 14, 2023

tacaswell mentioned this pull request

May 5, 2023

[ENH]: Add setter/getter methods for all keyword parameters to Figure.__init__#24617

Open

Copy link

Contributor

NoyHanan commentedMay 6, 2023

Hi@rcomer,
I would like to take over this pr, can you please give me permissions?
Thanks!

Copy link

Member

rcomer commentedMay 6, 2023

Thank you@NoyHanan. Please create a new branch and a new PR referencing this one. You couldgit cherry-pick the commits from here into your branch or write something new, whichever you prefer.