Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Don't manually invalidate cached lines in _update_transScale.#24654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ksunden merged 1 commit intomatplotlib:mainfromanntzer:utsl
Dec 7, 2022

Conversation

anntzer
Copy link
Contributor

Resetting transScale just above will invalidate any nodes that depend on it as well. (The manual line invalidation came in in ff3c65f to "fix log/linear toggle", but that toggle clearly works fine even with this removal; I assume that transform invalidation became better since then.)

PR Summary

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (andpytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a.. versionadded:: directive in the docstring and documented indoc/users/next_whats_new/
  • API changes are marked with a.. versionchanged:: directive in the docstring and documented indoc/api/next_api_changes/
  • Release notes conform with instructions innext_whats_new/README.rst ornext_api_changes/README.rst

Resetting transScale just above will invalidate any nodes that depend onit as well.  (The manual line invalidation came in in ff3c65f to "fixlog/linear toggle", but that toggle clearly works fine even with thisremoval; I assume that transform invalidation became better since then.)
@ksundenksunden added this to thev3.6.3 milestoneDec 7, 2022
@ksundenksunden merged commit85b1874 intomatplotlib:mainDec 7, 2022
@lumberbot-app
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.6.xgit pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 85b1874b0b7ed843329f962ed59d71c106da349f
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am "Backport PR #24654: Don't manually invalidate cached lines in _update_transScale."
  1. Push to a named branch:
git push YOURFORK v3.6.x:auto-backport-of-pr-24654-on-v3.6.x
  1. Create a PR against branch v3.6.x, I would have named this PR:

"Backport PR#24654 on branch v3.6.x (Don't manually invalidate cached lines in _update_transScale.)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove theStill Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free tosuggest an improvement.

@anntzeranntzer deleted the utsl branchDecember 7, 2022 17:54
rcomer pushed a commit to rcomer/matplotlib that referenced this pull requestDec 10, 2022
…in _update_transScaleManual backport required due to simple conflict caused by thefirst removed line being different in main and v3.6.x, havingpreviously been modified atmatplotlib#24634.
oscargus added a commit that referenced this pull requestDec 10, 2022
Backport PR#24654: Don't manually invalidate cached lines in _update_transScale
@ksundenksunden mentioned this pull requestFeb 20, 2023
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ksundenksundenksunden approved these changes

@oscargusoscargusoscargus approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.6.3
Development

Successfully merging this pull request may close these issues.

4 participants
@anntzer@ksunden@oscargus@rcomer
[8]ページ先頭
©2009-2025 Movatter.jp