Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Mnt/no reset axes#24626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Draft
tacaswell wants to merge2 commits intomatplotlib:main
base:main
Choose a base branch
Loading
fromtacaswell:mnt/no_reset_axes

Conversation

tacaswell
Copy link
Member

PR Summary

This makes our Artists very picky about being re-added to Axes / Figures once they have been removed. Currently there is enough checking in place that it should not be possible to try and add the Artist to more than one simultaneously, but it is not clear we actually do enough clean up to make these re-added Aritsts actually work. I suspect in most cases where users are removing / readding Aritsts they would be better off usingset_visible(), but I have no idea how common it actually is.

Open questions:

  • should this actually start a deprecation cycle where we warn about "going through None" on Artists?
  • should this wait for theArtistList deprecation to expire (if we are ever going to expire those)?

I think this is sufficiently tested, but needs API change notes, but waiting for the above decisions before writing them.

In any case, the change to the OffsetBox test should probably be pulled out and if we do not take this, find a way to make that error out for maybe other reasons.

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (andpytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).

Release Notes

  • API changes are marked with a.. versionchanged:: directive in the docstring and documented indoc/api/next_api_changes/

@tacaswell
Copy link
MemberAuthor

On consideration, this has sat for so long it can sit a bit longer. We have more than enough to try and get in for 3.7 so defer this to 3.8.

@sryu1
Copy link

Does this mean ArtistList does not work anymore? It seems like starting from 3.7.0, pop() function doesn't work on it...

@QuLogic
Copy link
Member

@sryu1
Copy link

Ah ok, thank you.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Projects
None yet
Milestone
future releases
Development

Successfully merging this pull request may close these issues.

4 participants
@tacaswell@sryu1@QuLogic@ksunden

[8]ページ先頭

©2009-2025 Movatter.jp