Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
Mnt/no reset axes#24626
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Mnt/no reset axes#24626
Uh oh!
There was an error while loading.Please reload this page.
Conversation
df7fe30
to5d60904
CompareOn consideration, this has sat for so long it can sit a bit longer. We have more than enough to try and get in for 3.7 so defer this to 3.8. |
sryu1 commentedMar 16, 2023
Does this mean ArtistList does not work anymore? It seems like starting from 3.7.0, pop() function doesn't work on it... |
That has nothing to do with this PR; seehttps://matplotlib.org/stable/api/prev_api_changes/api_changes_3.7.0.html#modification-of-axes-children-sublists |
sryu1 commentedMar 16, 2023
Ah ok, thank you. |
This is exactly the sort of error that this check is supposed to catch.
PR Summary
This makes our Artists very picky about being re-added to Axes / Figures once they have been removed. Currently there is enough checking in place that it should not be possible to try and add the Artist to more than one simultaneously, but it is not clear we actually do enough clean up to make these re-added Aritsts actually work. I suspect in most cases where users are removing / readding Aritsts they would be better off using
set_visible()
, but I have no idea how common it actually is.Open questions:
ArtistList
deprecation to expire (if we are ever going to expire those)?I think this is sufficiently tested, but needs API change notes, but waiting for the above decisions before writing them.
In any case, the change to the OffsetBox test should probably be pulled out and if we do not take this, find a way to make that error out for maybe other reasons.
PR Checklist
Documentation and Tests
pytest
passes)Release Notes
.. versionchanged::
directive in the docstring and documented indoc/api/next_api_changes/