Uh oh!
There was an error while loading.Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork7.9k
DOC: tweak wording on Figure.show warning#24607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Uh oh!
There was an error while loading.Please reload this page.
closesmatplotlib#22169Co-authored-by: Tim Hoffmann <2836374+timhoffm@users.noreply.github.com>
Uh oh!
There was an error while loading.Please reload this page.
lib/matplotlib/figure.py Outdated
| Some, but not all, GUI toolkits will register an input hook on | ||
| import. See :ref:`cp_integration` for more details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
My apologies, but I find these changes much more confusing than the original. What is an "input hook"? What is a "GUI toolkit", and why do they register an "input hook"? Where do they register it? and what does "on import" mean? On import of what?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Note that there is a typo in the previous paragraph "an GUI even loop"...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
It does include a link to the (much) longer explanation.
#22169 noted that they found a case where itdid work. The goal was to add a few more details about when you should expect this to work or not.
| If you're in a shell without input hook integration or executing a | ||
| python script, you should use `matplotlib.pyplot.show` with | ||
| ``block=True`` instead, which takes care of starting and running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
block=True is the default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The default depends on if we are in "interactive mode" or not.
Co-authored-by: Oscar Gustafsson <oscar.gustafsson@gmail.com>
Uh oh!
There was an error while loading.Please reload this page.
Co-authored-by: Jody Klymak <jklymak@gmail.com>
meeseeksdev backport to v3.6.x |
…607-on-v3.6.xBackport PR#24607 on branch v3.6.x (DOC: tweak wording on Figure.show warning)
PR Summary
closes#22169
PR Checklist
Documentation and Tests