Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

FIX: do not use deprecated API in gtk4 backend#24606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
oscargus merged 1 commit intomatplotlib:mainfromtacaswell:fix_gtk_closevent
Dec 4, 2022

Conversation

tacaswell
Copy link
Member

closes#24602

We do not currently test gtk4 on CI (see#22389)

carmaza reacted with hooray emoji
@tacaswelltacaswell added this to thev3.6.3 milestoneDec 3, 2022
@tacaswelltacaswell marked this pull request as ready for reviewDecember 3, 2022 20:44
@carmaza
Copy link

This fixed#24602 for me. Thanks for the quick fix!

@tacaswell
Copy link
MemberAuthor

Thanks for testing@carmaza !

@oscargusoscargus merged commit0aac9f1 intomatplotlib:mainDec 4, 2022
@lumberbot-app
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.6.xgit pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 0aac9f17b9373f66c709f436149568bda69595b3
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #24606: FIX: do not use deprecated API in gtk4 backend'
  1. Push to a named branch:
git push YOURFORK v3.6.x:auto-backport-of-pr-24606-on-v3.6.x
  1. Create a PR against branch v3.6.x, I would have named this PR:

"Backport PR#24606 on branch v3.6.x (FIX: do not use deprecated API in gtk4 backend)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove theStill Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free tosuggest an improvement.

@tacaswelltacaswell deleted the fix_gtk_closevent branchDecember 4, 2022 22:18
tacaswell pushed a commit to tacaswell/matplotlib that referenced this pull requestDec 4, 2022
…backendMerge pull requestmatplotlib#24606 from tacaswell/fix_gtk_closeventFIX: do not use deprecated API in gtk4 backend(cherry picked from commit0aac9f1)
oscargus added a commit that referenced this pull requestDec 5, 2022
…-v3.6.xBackport PR#24606: FIX: do not use deprecated API in gtk4 backend
@ksundenksunden mentioned this pull requestFeb 20, 2023
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@timhoffmtimhoffmtimhoffm approved these changes

@oscargusoscargusoscargus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.6.3
Development

Successfully merging this pull request may close these issues.

close_event deprecated warning.
4 participants
@tacaswell@carmaza@timhoffm@oscargus
[8]ページ先頭
©2009-2025 Movatter.jp