Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

minor pep8 fix on every file#2460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
pelson merged 1 commit intomatplotlib:masterfromtacaswell:fix_future_import
Sep 26, 2013

Conversation

@tacaswell
Copy link
Member

The fromfuture ... line added in#2226 is three charachters too long according to pep8. This bulk-fixes this by breaking the import up into 4 seperate lines.

No matter what every file will need to be touched again, and 4 separate imports seemed better style to me than any other way to break it up.

sed is a handy tool.

@pelson
Copy link
Member

and 4 separate imports seemed better style to me than any other way to break it up.

I don't necessarily agree. Adding parentheses is better IMHO:

from __future__ import (absolute_import, division, print_function,                        unicode_literals)

I'd like to get some other feedback on that before you have to re-write yoursed command though 😄

@mdboom
Copy link
Member

Given the restriction that__future__ come first, I had no idea it could be broken up. For consistency with other imports though, where we don't currently enforce that each "from x import y" has only one "y", I think@pelson's suggestion is preferable.

…achterstoo long according to pep8.  This bulk-fixes every file in the library.
@tacaswell
Copy link
MemberAuthor

Forcibly replaced the old commit with a new one using pelson's suggestion. Also caught a few files I missed last time.

pelson added a commit that referenced this pull requestSep 26, 2013
PEP8 fix on every file's from __future__ import
@pelsonpelson merged commit799cbe6 intomatplotlib:masterSep 26, 2013
@tacaswelltacaswell deleted the fix_future_import branchSeptember 26, 2013 14:32
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tacaswell@pelson@mdboom

[8]ページ先頭

©2009-2025 Movatter.jp