Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Check for errors/warnings on failed doc-builds#24598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 1 commit intomatplotlib:mainfromoscargus:docbuilderrors
Dec 4, 2022

Conversation

oscargus
Copy link
Member

@oscargusoscargus commentedDec 3, 2022•
edited
Loading

PR Summary

I'm quite sure that this helps with#22176 (comment)

Still not good enough to solve the whole issue, but at least useable now...

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (andpytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a.. versionadded:: directive in the docstring and documented indoc/users/next_whats_new/
  • API changes are marked with a.. versionchanged:: directive in the docstring and documented indoc/api/next_api_changes/
  • Release notes conform with instructions innext_whats_new/README.rst ornext_api_changes/README.rst

@oscargus
Copy link
MemberAuthor

This works now:

#!/bin/bash -eo pipefail(grep "WARNING\|ERROR" /tmp/sphinxerrorswarnings.log || echo "No errors or warnings")WARNING: [autosummary] failed to import matplotlib.artist.Artist.get_foogure./home/circleci/project/doc/api/artist_api.rst:114: WARNING: autosummary: failed to import Artist.get_foogure.CircleCI received exit code 0

@oscargusoscargus added the Documentation: buildbuilding the docs labelDec 3, 2022
@oscargusoscargus added this to thev3.6-doc milestoneDec 3, 2022
@timhoffmtimhoffm merged commit8a7a53a intomatplotlib:mainDec 4, 2022
@lumberbot-app
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.6.xgit pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 8a7a53aa9cf2d0c70186b40bde5555264b3845c4
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #24598: Check for errors/warnings on failed doc-builds'
  1. Push to a named branch:
git push YOURFORK v3.6.x:auto-backport-of-pr-24598-on-v3.6.x
  1. Create a PR against branch v3.6.x, I would have named this PR:

"Backport PR#24598 on branch v3.6.x (Check for errors/warnings on failed doc-builds)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove theStill Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free tosuggest an improvement.

@lumberbot-app
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.6.2-docgit pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 8a7a53aa9cf2d0c70186b40bde5555264b3845c4
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #24598: Check for errors/warnings on failed doc-builds'
  1. Push to a named branch:
git push YOURFORK v3.6.2-doc:auto-backport-of-pr-24598-on-v3.6.2-doc
  1. Create a PR against branch v3.6.2-doc, I would have named this PR:

"Backport PR#24598 on branch v3.6.2-doc (Check for errors/warnings on failed doc-builds)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove theStill Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free tosuggest an improvement.

@rcomer
Copy link
Member

I think the conflict is because#23868 was not backported. I just triggered that.

@rcomer
Copy link
Member

@meeseeksdev backport to v3.6.2-doc

@rcomer
Copy link
Member

Still needs backport to v3.6.x after#24612 is merged. But currently CI is failing on all v3.6.x PRs.

tacaswell added a commit that referenced this pull requestDec 4, 2022
…598-on-v3.6.2-docBackport PR#24598 on branch v3.6.2-doc (Check for errors/warnings on failed doc-builds)
@tacaswell
Copy link
Member

@meeseeksdev backport to v3.6.x

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestDec 4, 2022
@oscargusoscargus deleted the docbuilderrors branchDecember 4, 2022 16:29
rcomer added a commit that referenced this pull requestDec 4, 2022
…598-on-v3.6.xBackport PR#24598 on branch v3.6.x (Check for errors/warnings on failed doc-builds)
@ksundenksunden mentioned this pull requestFeb 20, 2023
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Labels
Documentation: buildbuilding the docs
Projects
None yet
Milestone
v3.6-doc
Development

Successfully merging this pull request may close these issues.

4 participants
@oscargus@rcomer@tacaswell@timhoffm
[8]ページ先頭
©2009-2025 Movatter.jp