Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

DOC: add "See Also: draw_idle" reference to pyplot.draw#24584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tacaswell merged 1 commit intomatplotlib:mainfromhukaidong:draw_doc
Dec 5, 2022
Merged

DOC: add "See Also: draw_idle" reference to pyplot.draw#24584

tacaswell merged 1 commit intomatplotlib:mainfromhukaidong:draw_doc
Dec 5, 2022

Conversation

hukaidong
Copy link
Contributor

PR Summary

This is a simple solution following the issue#24578. Adding a referencedraw_idle may reduce confusion to audiences who is visiting this page.

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (andpytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a.. versionadded:: directive in the docstring and documented indoc/users/next_whats_new/
  • API changes are marked with a.. versionchanged:: directive in the docstring and documented indoc/api/next_api_changes/
  • Release notes conform with instructions innext_whats_new/README.rst ornext_api_changes/README.rst

@tacaswelltacaswell modified the milestones:v3.6-doc,v3.6.3Dec 2, 2022
@tacaswelltacaswell reopened thisDec 2, 2022
@tacaswell
Copy link
Member

Not sure what was wrong with circle, "powercycled" to see if that fixed it.

@tacaswell
Copy link
Member

I am still confused about why circle is failing.

@hukaidong
Copy link
ContributorAuthor

hukaidong commentedDec 4, 2022•
edited
Loading

I am still confused about why circle is failing.

You mean the circleCI pipeline? I think it fails in every pull request but don't know why. Here's what they said

Could not find a usable config.yml, you may have revoked the CircleCI OAuth app.
Please sign out of CircleCI and log back in with your VCS before triggering a new pipeline.

So it looks like some account configuration issue

@tacaswell
Copy link
Member

Circle is running on other PRs, would you be willing to rebase your PR onto current main (or I can do it for you, but do not want to force-push to your branch with out permission)?

@hukaidong
Copy link
ContributorAuthor

Circle is running on other PRs, would you be willing to rebase your PR onto current main (or I can do it for you, but do not want to force-push to your branch with out permission)?

rebased to latest commit but the problem seems consist

@hukaidong
Copy link
ContributorAuthor

Circle is running on other PRs, would you be willing to rebase your PR onto current main (or I can do it for you, but do not want to force-push to your branch with out permission)?

BTW you are welcomed if you want to do more test and force push on this branch. That will be much more easier

@tacaswell
Copy link
Member

If circle on#24622 passes I will merge this PR.

@tacaswell
Copy link
Member

Seehttps://gitter.im/matplotlib/matplotlib?at=638d07ac4abb3f4684a40439 for discussion debugging this.

Our theory is that there is something confused on the circleCI side with@hukaidong 's account which is the source of the problem.

@tacaswelltacaswell merged commitaa1c538 intomatplotlib:mainDec 5, 2022
@tacaswell
Copy link
Member

CI passed on#24622 so I'm going to merge this PR and close mine.

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestDec 5, 2022
tacaswell added a commit that referenced this pull requestDec 5, 2022
…584-on-v3.6.xBackport PR#24584 on branch v3.6.x (DOC: add "See Also: draw_idle" reference to pyplot.draw)
@hukaidonghukaidong deleted the draw_doc branchDecember 5, 2022 20:05
@ksundenksunden mentioned this pull requestFeb 20, 2023
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@tacaswelltacaswelltacaswell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.6.3
Development

Successfully merging this pull request may close these issues.

2 participants
@hukaidong@tacaswell
[8]ページ先頭
©2009-2025 Movatter.jp