Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Add explicit permissions to GitHub Actions#24579

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tacaswell merged 1 commit intomatplotlib:mainfromQuLogic:action-permissions
Dec 2, 2022

Conversation

QuLogic
Copy link
Member

PR Summary

While everything we do is basically public, there's no reason to give the tokens on these jobs full permissions. (Note, once a single item is added, all other permissions are disabled.)

Also update the CircleCI check to the action's latest recommended jobs.

PR Checklist

Documentation and Tests

  • [n/a] Has pytest style unit tests (andpytest passes)
  • [n/a] Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • [n/a] New plotting related features are documented with examples.

Release Notes

  • [n/a] New features are marked with a.. versionadded:: directive in the docstring and documented indoc/users/next_whats_new/
  • [n/a] API changes are marked with a.. versionchanged:: directive in the docstring and documented indoc/api/next_api_changes/
  • [n/a] Release notes conform with instructions innext_whats_new/README.rst ornext_api_changes/README.rst

@QuLogicQuLogic added topic: testing Maintenance CI: Run cibuildwheelRun wheel building tests on a PR labelsDec 2, 2022
@QuLogicQuLogic added this to thev3.6.3 milestoneDec 2, 2022
Also update the CircleCI check to the action's latest recommended jobs.
@QuLogic
Copy link
MemberAuthor

QuLogic commentedDec 2, 2022•
edited
Loading

I threw in a few bugs, and they were correctly reported, so I've removed them now. Not 100% confident on the nightly bits, as the GitHub docs are a bit vague on what the permissions do, but I think they're correct.

story645 reacted with thumbs up emoji

@tacaswelltacaswell merged commit24f9128 intomatplotlib:mainDec 2, 2022
@lumberbot-app
Copy link

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout v3.6.xgit pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 24f912845dd2765c86863945ed9a5fda82ed418b
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #24579: Add explicit permissions to GitHub Actions'
  1. Push to a named branch:
git push YOURFORK v3.6.x:auto-backport-of-pr-24579-on-v3.6.x
  1. Create a PR against branch v3.6.x, I would have named this PR:

"Backport PR#24579 on branch v3.6.x (Add explicit permissions to GitHub Actions)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove theStill Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free tosuggest an improvement.

tacaswell added a commit to tacaswell/matplotlib that referenced this pull requestDec 2, 2022
Merge pull requestmatplotlib#24579 from QuLogic/action-permissionsAdd explicit permissions to GitHub Actions(cherry picked from commit24f9128)
@QuLogicQuLogic deleted the action-permissions branchDecember 3, 2022 00:29
QuLogic added a commit that referenced this pull requestDec 3, 2022
…-v3.6.xBackport PR#24579: Add explicit permissions to GitHub Actions
@ksundenksunden mentioned this pull requestFeb 20, 2023
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ksundenksundenksunden approved these changes

Assignees
No one assigned
Labels
CI: Run cibuildwheelRun wheel building tests on a PRMaintenancetopic: testing
Projects
None yet
Milestone
v3.6.3
Development

Successfully merging this pull request may close these issues.

3 participants
@QuLogic@ksunden@tacaswell
[8]ページ先頭
©2009-2025 Movatter.jp