Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

DOC: add note about enabling c++11 support for old gcc#24540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ksunden merged 1 commit intomatplotlib:mainfromtacaswell:doc_old_gcc_note
Nov 29, 2022

Conversation

tacaswell
Copy link
Member

Closes#24530

@rcomer Can you confirm if this works for you?

@tacaswelltacaswell added this to thev3.6-doc milestoneNov 24, 2022
@tacaswell
Copy link
MemberAuthor

This is the "lazy" option.

@QuLogicQuLogic requested a review fromrcomerNovember 24, 2022 07:04
Copy link
Member

@rcomerrcomer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Thanks@tacaswell, I tried

export CXXFLAGS=-std=c++11

before the install, but got the same error. Am I misunderstanding how to set this?

@oscargus
Copy link
Member

oscargus commentedNov 24, 2022
edited
Loading

It seems like one have to setCFLAGS asgcc, notg++, is used to compile some cpp-files... (It is OK not to setCXXFLAGS, at least on my CentOS 7 install.)

You will get a warning though for some of the compile steps:

cc1: warning: command line option ‘-std=c++11’ is valid for C++/ObjC++ but not for C [enabled by default]

@rcomer
Copy link
Member

Thanks@oscargus

export CFLAGS=-std=c++11

worked for me too. I'm on RHEL7 (apparently next year we get RHEL9...)

@oscargus
Copy link
Member

A small follow-up on this. Although it compiles and looks like it installs correctly there is also another message of interest:

/local/data1/miniconda3/compiler_compat/ld: build/freetype-2.6.1/objs/.libs/libfreetype.a(ftinit.o): plugin needed to handle lto object

and running mpl leads to

ImportError: /local/data1/matplotlib/lib/matplotlib/ft2font.cpython-39-x86_64-linux-gnu.so: undefined symbol: FT_Load_Glyph

Do you get similar behavior@rcomer or does it work for you?

(This is for gcc 4.8.5, but I also have 7.3.1 and there it builds without problem, so back to a working version now...)

@rcomer
Copy link
Member

rcomer commentedNov 25, 2022
edited
Loading

@oscargus I don't see that message about the plugin, and I just used the environment to reproduce#24545.

oscargus reacted with thumbs up emoji

@rcomer
Copy link
Member

@tacaswell I see this is 2 commits. Should I squash-merge or just commit both or something else?

Closesmatplotlib#24530This will produce warnings, but will compile.
@tacaswell
Copy link
MemberAuthor

I'll squash this to one (probably should have done that initially).

We tend to reserve squash-merging for PRs with many commits and a contributor who does not feel comfortable squashing them selves.

rcomer reacted with thumbs up emoji

@ksunden
Copy link
Member

Cycling CI because it looked like a few checks had network errors that were likely temporary

@ksundenksunden reopened thisNov 28, 2022
@QuLogic
Copy link
Member

You can do that directly in Circle; no need to modify the PR.

@ksundenksunden merged commit60660c5 intomatplotlib:mainNov 29, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestNov 29, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestNov 29, 2022
QuLogic added a commit that referenced this pull requestNov 29, 2022
…540-on-v3.6.xBackport PR#24540 on branch v3.6.x (DOC: add note about enabling c++11 support for old gcc)
QuLogic added a commit that referenced this pull requestNov 29, 2022
…540-on-v3.6.2-docBackport PR#24540 on branch v3.6.2-doc (DOC: add note about enabling c++11 support for old gcc)
@tacaswelltacaswell deleted the doc_old_gcc_note branchNovember 30, 2022 15:09
@ksundenksunden mentioned this pull requestFeb 20, 2023
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@QuLogicQuLogicQuLogic approved these changes

@ksundenksundenksunden approved these changes

@rcomerrcomerrcomer approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.6-doc
Development

Successfully merging this pull request may close these issues.

[Doc]: update minimum gcc version?
5 participants
@tacaswell@oscargus@rcomer@ksunden@QuLogic

[8]ページ先頭

©2009-2025 Movatter.jp