Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Fix potential issue in contour#24514

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
timhoffm merged 1 commit intomatplotlib:mainfromoscargus:contourfix
Nov 21, 2022
Merged

Conversation

oscargus
Copy link
Member

PR Summary

It may be that imin is never assigned. All other variables that are in the same if-clause have default values, so an option is to remove all those if we are sure that they will always be assigned a value. But probably safer to provide a default value for imin.

PR Checklist

Documentation and Tests

  • Has pytest style unit tests (andpytest passes)
  • Documentation is sphinx and numpydoc compliant (the docs shouldbuild without error).
  • New plotting related features are documented with examples.

Release Notes

  • New features are marked with a.. versionadded:: directive in the docstring and documented indoc/users/next_whats_new/
  • API changes are marked with a.. versionchanged:: directive in the docstring and documented indoc/api/next_api_changes/
  • Release notes conform with instructions innext_whats_new/README.rst ornext_api_changes/README.rst

@ksundenksunden added this to thev3.6.3 milestoneNov 21, 2022
@timhoffmtimhoffm merged commitf1e5de1 intomatplotlib:mainNov 21, 2022
meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull requestNov 21, 2022
QuLogic added a commit that referenced this pull requestNov 22, 2022
…514-on-v3.6.xBackport PR#24514 on branch v3.6.x (Fix potential issue in contour)
@oscargusoscargus deleted the contourfix branchNovember 22, 2022 07:42
@ksundenksunden mentioned this pull requestFeb 20, 2023
6 tasks
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ksundenksundenksunden approved these changes

@timhoffmtimhoffmtimhoffm approved these changes

Assignees
No one assigned
Projects
None yet
Milestone
v3.6.3
Development

Successfully merging this pull request may close these issues.

3 participants
@oscargus@ksunden@timhoffm

[8]ページ先頭

©2009-2025 Movatter.jp